Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1351663002: [simdjs] Update spec version to 0.8.4 (Closed)

Created:
5 years, 3 months ago by gdeepti1
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[simdjs] Update spec version to 0.8.4 Merge ShiftRightArithmetic and ShiftRightLogical Functions. BUG=v8:4124 LOG=Y Committed: https://crrev.com/a633a38f08c937404574f9553c649ba6503e5f01 Cr-Commit-Position: refs/heads/master@{#30812}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Bill's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+325 lines, -325 lines) Patch
M src/harmony-simd.js View 8 chunks +10 lines, -10 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +311 lines, -311 lines 0 comments Download
M src/runtime/runtime-simd.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M test/simdjs/testcfg.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
gdeepti1
5 years, 3 months ago (2015-09-16 18:24:23 UTC) #2
bbudge
https://codereview.chromium.org/1351663002/diff/1/src/runtime/runtime-simd.cc File src/runtime/runtime-simd.cc (right): https://codereview.chromium.org/1351663002/diff/1/src/runtime/runtime-simd.cc#newcode461 src/runtime/runtime-simd.cc:461: #define SIMD_LSR_FUNCTION(type, lane_type, lane_bits, lane_count) \ It's a little ...
5 years, 3 months ago (2015-09-16 20:25:36 UTC) #3
gdeepti1
https://codereview.chromium.org/1351663002/diff/1/src/runtime/runtime-simd.cc File src/runtime/runtime-simd.cc (right): https://codereview.chromium.org/1351663002/diff/1/src/runtime/runtime-simd.cc#newcode461 src/runtime/runtime-simd.cc:461: #define SIMD_LSR_FUNCTION(type, lane_type, lane_bits, lane_count) \ On 2015/09/16 20:25:36, ...
5 years, 3 months ago (2015-09-16 20:42:08 UTC) #4
bbudge
LGTM thanks for doing this!
5 years, 3 months ago (2015-09-16 20:43:49 UTC) #5
Benedikt Meurer
lgtm
5 years, 3 months ago (2015-09-17 03:52:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351663002/20001
5 years, 3 months ago (2015-09-17 17:30:11 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-17 17:54:52 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 17:55:11 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a633a38f08c937404574f9553c649ba6503e5f01
Cr-Commit-Position: refs/heads/master@{#30812}

Powered by Google App Engine
This is Rietveld 408576698