Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1351653002: [sql] sqlite3_initialize() before additional entry point. (Closed)

Created:
5 years, 3 months ago by Scott Hess - ex-Googler
Modified:
5 years, 3 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sql] sqlite3_initialize() before additional entry point. sqlite3_vfs_find() added an additional entry point in Delete(), which is static. BUG=84094 TBR=erg@chromium.org Committed: https://crrev.com/702467624c18fea506c9fd208d477ecbd3e4ee7e Cr-Commit-Position: refs/heads/master@{#349179}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M sql/connection.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351653002/1
5 years, 3 months ago (2015-09-16 17:54:43 UTC) #3
Scott Hess - ex-Googler
Reviewer michaeln->erg because this was erg's change originally.
5 years, 3 months ago (2015-09-16 17:58:52 UTC) #5
Elliot Glaysher
lgtm
5 years, 3 months ago (2015-09-16 18:10:08 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-16 18:52:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351653002/1
5 years, 3 months ago (2015-09-16 18:57:34 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-16 19:05:02 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/702467624c18fea506c9fd208d477ecbd3e4ee7e Cr-Commit-Position: refs/heads/master@{#349179}
5 years, 3 months ago (2015-09-16 19:05:41 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:58:47 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/702467624c18fea506c9fd208d477ecbd3e4ee7e
Cr-Commit-Position: refs/heads/master@{#349179}

Powered by Google App Engine
This is Rietveld 408576698