Fix WebSpeech API for OOPIF based <webview>

Fix WebSpeech API for OOPIF based <webview>.

In OOPIF based <webview>, BrowserPluginGuest isn't used much and the
plan is to remove its usage in --site-per-process. However, the
Web Speech API relies on BrowserPluginGuest to return its embedder
WebContents. I've made it so that we ask for the WebContentsImpl to
return its embedder or outer WebContents instead of going through
BrowserPluginGuest.

TBR=jam@chromium.org for chromium.fyi.json
BUG=533647
Test=Try WebSpeech API from a Chrome App <webview>, with --site-per-process.
This should work and not crash the browser/ process.

Committed: https://crrev.com/8e16ddfdefd2d32078e178fa98df1958990d0cbd
Cr-Commit-Position: refs/heads/master@{#351018}

[lazyboy, 2015-09-18 22:04:19]

lazyboy@chromium.org changed reviewers:
+ creis@chromium.org

[Charlie Reis, 2015-09-24 05:09:14]

Thanks, and sorry for the long delay!  LGTM with nits.

https://codereview.chromium.org/1351643003/diff/40001/content/browser/speech/...
File content/browser/speech/speech_recognition_dispatcher_host.cc (right):

https://codereview.chromium.org/1351643003/diff/40001/content/browser/speech/...
content/browser/speech/speech_recognition_dispatcher_host.cc:106: // If the
speech API request was from an outer WebContents or a guest, save
s/outer/inner/, right?

https://codereview.chromium.org/1351643003/diff/40001/content/browser/web_con...
File content/browser/web_contents/web_contents_impl.h (right):

https://codereview.chromium.org/1351643003/diff/40001/content/browser/web_con...
content/browser/web_contents/web_contents_impl.h:695: // of our
BrowserPluginEmbedder.
nit: of the BrowserPluginEmbedder, if |this| is a guest.

https://codereview.chromium.org/1351643003/diff/40001/content/browser/web_con...
content/browser/web_contents/web_contents_impl.h:696: WebContentsImpl*
GetOuterWebContents();
nit: Declare this above GetBrowserPluginGuest(), since it's related to those
methods.

[lazyboy, 2015-09-28 03:37:16]

https://codereview.chromium.org/1351643003/diff/40001/content/browser/speech/...
File content/browser/speech/speech_recognition_dispatcher_host.cc (right):

https://codereview.chromium.org/1351643003/diff/40001/content/browser/speech/...
content/browser/speech/speech_recognition_dispatcher_host.cc:106: // If the
speech API request was from an outer WebContents or a guest, save
On 2015/09/24 05:09:14, Charlie Reis wrote:
> s/outer/inner/, right?

Yes, thanks.
Done.

https://codereview.chromium.org/1351643003/diff/40001/content/browser/web_con...
File content/browser/web_contents/web_contents_impl.h (right):

https://codereview.chromium.org/1351643003/diff/40001/content/browser/web_con...
content/browser/web_contents/web_contents_impl.h:695: // of our
BrowserPluginEmbedder.
On 2015/09/24 05:09:14, Charlie Reis wrote:
> nit: of the BrowserPluginEmbedder, if |this| is a guest.

Done.

https://codereview.chromium.org/1351643003/diff/40001/content/browser/web_con...
content/browser/web_contents/web_contents_impl.h:696: WebContentsImpl*
GetOuterWebContents();
On 2015/09/24 05:09:14, Charlie Reis wrote:
> nit: Declare this above GetBrowserPluginGuest(), since it's related to those
> methods.

Done.

[lazyboy, 2015-09-28 03:37:26]

The CQ bit was checked by lazyboy@chromium.org

[lazyboy, 2015-09-28 03:37:26]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org
Link to the patchset: https://codereview.chromium.org/1351643003/#ps60001
(title: "address nits from Charlie")

[commit-bot: I haz the power, 2015-09-28 03:37:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1351643003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1351643003/60001

[commit-bot: I haz the power, 2015-09-28 03:42:06]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-09-28 03:42:44]

Patchset 4 (id:??) landed as
https://crrev.com/8e16ddfdefd2d32078e178fa98df1958990d0cbd
Cr-Commit-Position: refs/heads/master@{#351018}