Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 135163006: WebFrame exports size information for remote frames. (Closed)

Created:
6 years, 10 months ago by kenrb
Modified:
6 years, 10 months ago
Reviewers:
eseidel
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

WebFrame exports size information for remote frames. WebFrameImpl::setIsRemote() becomes an initialization point for remote frames, called when a child frame is swapped out. Right now it only causes necessary rendering parameters to be exported and sent to the new child frame renderer process, later on it can be extended to trigger the RemoteFrame creation process. The size information is necessary for the child frame renderer to know the viewport size that it is rendering into. If the frame size changes dynamically we currently don't have a way to propagate this. FrameView seems like the best place to trap a size change event but the current plan is to get rid of that for out of process iframes. We'll have to add that when we have a better idea of how RemoteFrame rendering will work. R=eseidel@chromium.org BUG=325803 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167201

Patch Set 1 #

Patch Set 2 : Resolved merge conflict with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M Source/web/WebFrameImpl.h View 2 chunks +5 lines, -0 lines 0 comments Download
M Source/web/WebFrameImpl.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download
M public/web/WebFrame.h View 1 chunk +4 lines, -0 lines 0 comments Download
M public/web/WebFrameClient.h View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kenrb
Eric: PTAL?
6 years, 10 months ago (2014-02-04 16:57:26 UTC) #1
kenrb
Eric: ping? (I know you've been traveling, just making sure this stays on your list)
6 years, 10 months ago (2014-02-11 21:12:40 UTC) #2
eseidel
lgtm OK.
6 years, 10 months ago (2014-02-14 00:12:42 UTC) #3
kenrb
The CQ bit was checked by kenrb@chromium.org
6 years, 10 months ago (2014-02-14 14:28:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenrb@chromium.org/135163006/30001
6 years, 10 months ago (2014-02-14 14:28:32 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 15:42:46 UTC) #6
Message was sent while issue was closed.
Change committed as 167201

Powered by Google App Engine
This is Rietveld 408576698