chrome/browser/resources/settings/languages_page/compiled_resources.gyp - Issue 1351623008: MD Settings: Languages model for language pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/languages_page/compiled_resources.gyp

Issue 1351623008: MD Settings: Languages model for language pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SingletonPrefs

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/advanced_page/advanced_page.html ('k') | chrome/browser/resources/settings/languages_page/languages_model.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/languages_page/compiled_resources.gyp

diff --git a/chrome/browser/resources/settings/languages_page/compiled_resources.gyp b/chrome/browser/resources/settings/languages_page/compiled_resources.gyp

index b1976cd503cdb98fc6f664258c771d652a2158a0..f8ed0812ba1ae3a72d3df2d21a34569017ad47f4 100644

--- a/chrome/browser/resources/settings/languages_page/compiled_resources.gyp

+++ b/chrome/browser/resources/settings/languages_page/compiled_resources.gyp

@@ -4,12 +4,32 @@

{

'targets': [

{

+ 'target_name': 'languages_model',

+ 'variables': {

+ 'depends': [

+ '../prefs/prefs_types.js',

+ '../prefs/compiled_resources.gyp:prefs',

+ '../../../../../ui/webui/resources/js/compiled_resources.gyp:assert',

+ '../../../../../ui/webui/resources/js/compiled_resources.gyp:cr',

+ ],

+ 'externs': [

+ '<(EXTERNS_DIR)/chrome_send.js',

+ '../../../../../third_party/closure_compiler/externs/language_settings_private.js'

+ ],

+ },

+ 'includes': ['../../../../../third_party/closure_compiler/compile_js.gypi'],

+ },

+ {

'target_name': 'languages_page',

'variables': {

'depends': [

'../../../../../ui/webui/resources/js/compiled_resources.gyp:assert',

'../../../../../ui/webui/resources/js/compiled_resources.gyp:cr',

'../../../../../ui/webui/resources/js/compiled_resources.gyp:load_time_data',

+ '../settings_page/settings_animated_pages.js',

+ '../prefs/prefs_types.js',

+ '../prefs/compiled_resources.gyp:prefs',

michaelpg 2015/09/21 02:22:54 This is a pain: languages_model depends on prefs a

+ 'languages_model.js',

michaelpg 2015/09/21 07:53:00 Same thing here: adding languages_model.js seems t

'externs': [

'../../../../../third_party/closure_compiler/externs/language_settings_private.js',