Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1351623003: Remove transitional GN build variable. (Closed)

Created:
5 years, 3 months ago by brettw
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke, dpranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove transitional GN build variable. The using_new_optimization_config existed to allow a multi-sided V8 build update that is now complete. TBR=dpranke Committed: https://crrev.com/ae96775ac803adcc2a1ce95064ea46a6b75b95bf Cr-Commit-Position: refs/heads/master@{#349212}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M build/config/BUILDCONFIG.gn View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
brettw
5 years, 3 months ago (2015-09-16 19:34:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351623003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351623003/1
5 years, 3 months ago (2015-09-16 19:35:16 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/96432)
5 years, 3 months ago (2015-09-16 20:12:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351623003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351623003/1
5 years, 3 months ago (2015-09-16 20:23:22 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-16 20:36:03 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ae96775ac803adcc2a1ce95064ea46a6b75b95bf Cr-Commit-Position: refs/heads/master@{#349212}
5 years, 3 months ago (2015-09-16 20:36:50 UTC) #9
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-16 20:38:36 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 13:00:13 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae96775ac803adcc2a1ce95064ea46a6b75b95bf
Cr-Commit-Position: refs/heads/master@{#349212}

Powered by Google App Engine
This is Rietveld 408576698