Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1351533004: share code between SkGr and Cacherator (Closed)

Created:
5 years, 3 months ago by reed1
Modified:
5 years, 3 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

share code between SkGr and Cacherator BUG=skia: Committed: https://skia.googlesource.com/skia/+/3322a8137d12255258a937897389ea90ca1ee6fa

Patch Set 1 #

Total comments: 2

Patch Set 2 : captured strict check in a helper function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -23 lines) Patch
M include/gpu/SkGr.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkImageCacherator.cpp View 3 chunks +2 lines, -10 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 chunks +9 lines, -5 lines 0 comments Download
M src/gpu/SkGr.cpp View 2 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351533004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351533004/1
5 years, 3 months ago (2015-09-16 16:05:14 UTC) #2
reed1
ptal
5 years, 3 months ago (2015-09-16 16:05:49 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-16 16:14:20 UTC) #6
robertphillips
lgtm + a suggestion https://codereview.chromium.org/1351533004/diff/1/src/gpu/SkGpuDevice.cpp File src/gpu/SkGpuDevice.cpp (right): https://codereview.chromium.org/1351533004/diff/1/src/gpu/SkGpuDevice.cpp#newcode1068 src/gpu/SkGpuDevice.cpp:1068: It seems like this should ...
5 years, 3 months ago (2015-09-16 16:23:27 UTC) #7
reed1
https://codereview.chromium.org/1351533004/diff/1/src/gpu/SkGpuDevice.cpp File src/gpu/SkGpuDevice.cpp (right): https://codereview.chromium.org/1351533004/diff/1/src/gpu/SkGpuDevice.cpp#newcode1068 src/gpu/SkGpuDevice.cpp:1068: On 2015/09/16 16:23:27, robertphillips wrote: > It seems like ...
5 years, 3 months ago (2015-09-16 17:03:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351533004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351533004/20001
5 years, 3 months ago (2015-09-16 17:03:42 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-16 17:09:30 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/3322a8137d12255258a937897389ea90ca1ee6fa

Powered by Google App Engine
This is Rietveld 408576698