Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 135153002: Force download_from_google_storage --config to produce a read-only token (Closed)

Created:
6 years, 11 months ago by Ryan Tseng
Modified:
6 years, 11 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Force download_from_google_storage --config to produce a read-only token When download_from_google_storage --config is run, it should be implied that the user just wants to download, not upload. This change passes the '-r' flag into gsutil config, which requests a read-only scoped token rather than write token. This is saved in ~/.boto.depot_tools so that it doesn't conflict with a ~/.boto file crated later that may have write permissions. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=244276

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M download_from_google_storage.py View 2 chunks +4 lines, -2 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
Ryan Tseng
This should be a short change, can you take a look? Thanks.
6 years, 11 months ago (2014-01-10 23:30:00 UTC) #1
M-A Ruel
lgtm https://codereview.chromium.org/135153002/diff/1/download_from_google_storage.py File download_from_google_storage.py (right): https://codereview.chromium.org/135153002/diff/1/download_from_google_storage.py#newcode366 download_from_google_storage.py:366: os.path.expanduser('~/.boto.depot_tools')) Note that we've seen '~' expansion issues ...
6 years, 11 months ago (2014-01-10 23:31:59 UTC) #2
Ryan Tseng
https://codereview.chromium.org/135153002/diff/1/download_from_google_storage.py File download_from_google_storage.py (right): https://codereview.chromium.org/135153002/diff/1/download_from_google_storage.py#newcode366 download_from_google_storage.py:366: os.path.expanduser('~/.boto.depot_tools')) On 2014/01/10 23:32:00, M-A Ruel wrote: > Note ...
6 years, 11 months ago (2014-01-10 23:34:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@google.com/135153002/1
6 years, 11 months ago (2014-01-10 23:34:28 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 23:36:26 UTC) #5
Message was sent while issue was closed.
Change committed as 244276

Powered by Google App Engine
This is Rietveld 408576698