Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1206)

Issue 13515005: Adds support for CoreAudioUtil::IsChannelLayoutSupported() (II) (Closed)

Created:
7 years, 8 months ago by henrika (OOO until Aug 14)
Modified:
7 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Adds support for CoreAudioUtil::IsChannelLayoutSupported(). Original patch (https://codereview.chromium.org/12918026/) was reverted. TBR=tommi BUG=177872 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192046

Patch Set 1 #

Patch Set 2 : Fix for browser_tests on XP #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -15 lines) Patch
M media/audio/win/audio_manager_win.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M media/audio/win/core_audio_util_win.h View 1 chunk +8 lines, -0 lines 0 comments Download
M media/audio/win/core_audio_util_win.cc View 4 chunks +106 lines, -15 lines 2 comments Download
M media/audio/win/core_audio_util_win_unittest.cc View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
henrika (OOO until Aug 14)
Reason for reverting: http://build.chromium.org/p/chromium.win/buildstatus?builder=XP%20Tests%20%282%29&number=26559
7 years, 8 months ago (2013-04-03 07:52:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/henrika@chromium.org/13515005/3001
7 years, 8 months ago (2013-04-03 08:59:39 UTC) #2
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=130514
7 years, 8 months ago (2013-04-03 10:16:19 UTC) #3
henrika (OOO until Aug 14)
Committed patchset #2 manually as r192046 (presubmit successful).
7 years, 8 months ago (2013-04-03 10:54:53 UTC) #4
tommi (sloooow) - chröme
lgtm https://codereview.chromium.org/13515005/diff/3001/media/audio/win/core_audio_util_win.cc File media/audio/win/core_audio_util_win.cc (right): https://codereview.chromium.org/13515005/diff/3001/media/audio/win/core_audio_util_win.cc#newcode111 media/audio/win/core_audio_util_win.cc:111: static std::ostream& operator<<(std::ostream& os, nit: if this is ...
7 years, 8 months ago (2013-04-03 11:03:21 UTC) #5
henrika (OOO until Aug 14)
https://codereview.chromium.org/13515005/diff/3001/media/audio/win/core_audio_util_win.cc File media/audio/win/core_audio_util_win.cc (right): https://codereview.chromium.org/13515005/diff/3001/media/audio/win/core_audio_util_win.cc#newcode111 media/audio/win/core_audio_util_win.cc:111: static std::ostream& operator<<(std::ostream& os, Dale and I have "phased ...
7 years, 8 months ago (2013-04-03 11:14:15 UTC) #6
tommi (sloooow) - chröme
7 years, 8 months ago (2013-04-03 11:16:54 UTC) #7
It's fine as is.  I meant this more as something to keep in mind for future
CLs since this has already been committed.


On Wed, Apr 3, 2013 at 11:14 AM, <henrika@chromium.org> wrote:

>
> https://codereview.chromium.**org/13515005/diff/3001/media/**
>
audio/win/core_audio_util_win.**cc<https://codereview.chromium.org/13515005/diff/3001/media/audio/win/core_audio_util_win.cc>
> File media/audio/win/core_audio_**util_win.cc (right):
>
> https://codereview.chromium.**org/13515005/diff/3001/media/**
>
audio/win/core_audio_util_win.**cc#newcode111<https://codereview.chromium.org/13515005/diff/3001/media/audio/win/core_audio_util_win.cc#newcode111>
> media/audio/win/core_audio_**util_win.cc:111: static std::ostream&
> operator<<(std::ostream& os,
> Dale and I have "phased in" more logs from DVLOG to VLOG lately to be
> able to debug easier in release build. Guess I was thinking in these
> terms here. IS it OK to keep as is or do you want me to upload a new
> fix?
>
>
https://codereview.chromium.**org/13515005/<https://codereview.chromium.org/1...
>

Powered by Google App Engine
This is Rietveld 408576698