Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: chromecast/media/audio/cast_audio_output_stream_unittest.cc

Issue 1351493003: [Chromecast] Add a return value after NOTREACHED in tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chromecast/media/BUILD.gn ('K') | « chromecast/media/audio/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/media/audio/cast_audio_output_stream_unittest.cc
diff --git a/chromecast/media/audio/cast_audio_output_stream_unittest.cc b/chromecast/media/audio/cast_audio_output_stream_unittest.cc
index a1e491aa48b1d98e5852111e8da6266e96798620..8d885f957c98cf9adc13feb332def5b7097624c0 100644
--- a/chromecast/media/audio/cast_audio_output_stream_unittest.cc
+++ b/chromecast/media/audio/cast_audio_output_stream_unittest.cc
@@ -80,8 +80,12 @@ class FakeAudioPipelineDevice : public AudioPipelineDevice {
return kFramePending;
case PIPELINE_STATUS_ERROR:
return kFrameFailed;
+ default:
+ NOTREACHED();
}
- NOTREACHED();
+
+ // This will never be reached but is necessary for compiler warnings.
+ return kFrameFailed;
}
RenderingDelay GetRenderingDelay() const override { return RenderingDelay(); }
bool GetStatistics(Statistics* stats) const override { return false; }
« chromecast/media/BUILD.gn ('K') | « chromecast/media/audio/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698