Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 1351493003: [Chromecast] Add a return value after NOTREACHED in tests. (Closed)

Created:
5 years, 3 months ago by slan
Modified:
5 years, 3 months ago
Reviewers:
alokp, halliwell, gunsch
CC:
chromium-reviews, feature-media-reviews_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org, gunsch+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Add a return value after NOTREACHED in tests. Required to compile on internal ARM compiler. BUG= Committed: https://crrev.com/66aaf7e5ac9bd3f5c516b3ea0e36247359eefd5d Cr-Commit-Position: refs/heads/master@{#349997}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M chromecast/media/BUILD.gn View 1 chunk +1 line, -0 lines 1 comment Download
M chromecast/media/audio/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M chromecast/media/audio/cast_audio_output_stream_unittest.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
slan
Please see this build fix for the change recently introduced by WebAudio patch.
5 years, 3 months ago (2015-09-21 18:46:10 UTC) #2
slan
ping for review, this is breaking internal builds.
5 years, 3 months ago (2015-09-21 19:19:21 UTC) #3
gunsch
lgtm
5 years, 3 months ago (2015-09-21 19:24:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351493003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351493003/1
5 years, 3 months ago (2015-09-21 19:25:18 UTC) #7
alokp
https://codereview.chromium.org/1351493003/diff/1/chromecast/media/BUILD.gn File chromecast/media/BUILD.gn (right): https://codereview.chromium.org/1351493003/diff/1/chromecast/media/BUILD.gn#newcode19 chromecast/media/BUILD.gn:19: "audio/cast_audio_output_stream_unittest.cc", Is this required because we do not have ...
5 years, 3 months ago (2015-09-21 19:38:35 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-21 19:54:29 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 19:55:03 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66aaf7e5ac9bd3f5c516b3ea0e36247359eefd5d
Cr-Commit-Position: refs/heads/master@{#349997}

Powered by Google App Engine
This is Rietveld 408576698