Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: src/ic/ic.h

Issue 1351493002: Extra code to diagnose a crash bug. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Ports. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/ic/ic.h
diff --git a/src/ic/ic.h b/src/ic/ic.h
index ba606f9ecd770fe7ca38b88d8d495dc00b4f1d75..135e1643d93e559f3ed04a8cc8500d1a396cdee6 100644
--- a/src/ic/ic.h
+++ b/src/ic/ic.h
@@ -323,8 +323,18 @@ class LoadIC : public IC {
}
// Code generator routines.
- static void GenerateInitialize(MacroAssembler* masm) { GenerateMiss(masm); }
- static void GenerateMiss(MacroAssembler* masm);
+
+ // TODO(jkummerow): remove the stress parameter and these stress constants
Jakob Kummerow 2015/09/16 13:57:22 nit: s/remove/Remove/, and the next two lines fit
mvstanton 2015/09/16 14:55:41 Done.
+ // when
+ // a crash bug is fixed.
+ static const int kStressNone = 0;
+ static const int kStressInit = 1;
+ static const int kStressDispatcher = 2;
+ static const int kStressBuiltin = 3;
+ static void GenerateInitialize(MacroAssembler* masm) {
+ GenerateMiss(masm, kStressInit);
+ }
+ static void GenerateMiss(MacroAssembler* masm, int stress = kStressNone);
static void GenerateRuntimeGetProperty(MacroAssembler* masm,
LanguageMode language_mode);
static void GenerateNormal(MacroAssembler* masm, LanguageMode language_mode);
« no previous file with comments | « src/ic/ia32/ic-ia32.cc ('k') | src/ic/mips/ic-mips.cc » ('j') | src/ic/x64/ic-x64.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698