Extra code to diagnose a crash bug.

Extra code to diagnose a crash bug.

This will catch an invalid receiver before being passed to a load ic miss
handler in the runtime.

BUG=
R=jkummerow@chromium.org

Committed: https://crrev.com/afba4792dff0b423c4beae905ac3c40da8fec22e
Cr-Commit-Position: refs/heads/master@{#30768}

[mvstanton, 2015-09-16 11:26:19]

Hi Jakob, here is the CL when/if it's necessary, thx!
--Michael

[Jakob Kummerow, 2015-09-16 13:57:22]

LGTM with nits.

As discussed, please also replace the instance type check in
EmitNamedPropertyLoad in full-codegen-x64.cc with the same kind of map
comparison you've built for the handler.

Thanks for your help with this bug!

https://codereview.chromium.org/1351493002/diff/20001/src/ic/ic.h
File src/ic/ic.h (right):

https://codereview.chromium.org/1351493002/diff/20001/src/ic/ic.h#newcode327
src/ic/ic.h:327: // TODO(jkummerow): remove the stress parameter and these
stress constants
nit: s/remove/Remove/, and the next two lines fit on one.

https://codereview.chromium.org/1351493002/diff/20001/src/ic/x64/ic-x64.cc
File src/ic/x64/ic-x64.cc (right):

https://codereview.chromium.org/1351493002/diff/20001/src/ic/x64/ic-x64.cc#ne...
src/ic/x64/ic-x64.cc:680: // Sanity check: The loaded value must be a JS-exposed
kind of object,
nit: s/loaded value/receiver/

[mvstanton, 2015-09-16 14:55:41]

Happy to help, thx for the review...submitting..

https://codereview.chromium.org/1351493002/diff/20001/src/ic/ic.h
File src/ic/ic.h (right):

https://codereview.chromium.org/1351493002/diff/20001/src/ic/ic.h#newcode327
src/ic/ic.h:327: // TODO(jkummerow): remove the stress parameter and these
stress constants
On 2015/09/16 13:57:22, Jakob wrote:
> nit: s/remove/Remove/, and the next two lines fit on one.

Done.

https://codereview.chromium.org/1351493002/diff/20001/src/ic/x64/ic-x64.cc
File src/ic/x64/ic-x64.cc (right):

https://codereview.chromium.org/1351493002/diff/20001/src/ic/x64/ic-x64.cc#ne...
src/ic/x64/ic-x64.cc:680: // Sanity check: The loaded value must be a JS-exposed
kind of object,
On 2015/09/16 13:57:22, Jakob wrote:
> nit: s/loaded value/receiver/

Done.

[mvstanton, 2015-09-16 14:55:57]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2015-09-16 14:55:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1351493002/#ps40001
(title: "Code comments.")

[commit-bot: I haz the power, 2015-09-16 14:56:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1351493002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1351493002/40001

[commit-bot: I haz the power, 2015-09-16 15:38:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-16 15:39:02]

Patchset 3 (id:??) landed as
https://crrev.com/afba4792dff0b423c4beae905ac3c40da8fec22e
Cr-Commit-Position: refs/heads/master@{#30768}