content/renderer/media/video_track_recorder.cc - Issue 1351473006: WebmMuxer-MediaRecorderHandler: thread hopping and data ownership

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/video_track_recorder.cc

Issue 1351473006: WebmMuxer-MediaRecorderHandler: thread hopping and data ownership (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: miu@ proposal Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/media_recorder_handler.cc ('K') | « content/renderer/media/video_track_recorder.h ('k') | content/renderer/media/video_track_recorder_unittest.cc » ('j') | media/capture/webm_muxer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/video_track_recorder.cc

diff --git a/content/renderer/media/video_track_recorder.cc b/content/renderer/media/video_track_recorder.cc

index da2b1c2414f2690dcfd3f658f11844cd6264f729..15daadfd9dbd79800c235a0793c280de0038c3ef 100644

--- a/content/renderer/media/video_track_recorder.cc

+++ b/content/renderer/media/video_track_recorder.cc

@@ -11,6 +11,7 @@

#include "base/time/time.h"

#include "base/trace_event/trace_event.h"

#include "media/base/video_frame.h"

+#include "ui/gfx/geometry/size.h"

extern "C" {

// VPX_CODEC_DISABLE_COMPAT excludes parts of the libvpx API that provide

@@ -51,8 +52,7 @@ void OnFrameEncodeCompleted(

bool keyframe) {

DVLOG(1) << (keyframe ? "" : "non ") << "keyframe "<< data->length() << "B, "

<< capture_timestamp << " ms";

- on_encoded_video_cb.Run(frame, base::StringPiece(*data), capture_timestamp,

- keyframe);

+ on_encoded_video_cb.Run(frame, data.Pass(), capture_timestamp, keyframe);

}

} // anonymous namespace