WebmMuxer-MediaRecorderHandler: thread hopping and data ownership

content/renderer/media/media_recorder_handler_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "content/child/child_process.h"
 #include "content/renderer/media/media_recorder_handler.h"
 #include "content/renderer/media/mock_media_stream_registry.h"
 #include "media/base/video_frame.h"
@@ skipping 39 matching lines @@
   bool recording() const { return media_recorder_handler_->recording_; }
   bool hasVideoRecorders() const {
     return !media_recorder_handler_->video_recorders_.empty();
   }
 
   void OnVideoFrameForTesting(const scoped_refptr<media::VideoFrame>& frame) {
     media_recorder_handler_->OnVideoFrameForTesting(frame,
                                                     base::TimeTicks::Now());
   }
 
-  // The Class under test. Needs to be scoped_ptr to force its destruction.
-  scoped_ptr<MediaRecorderHandler> media_recorder_handler_;
-
   // A ChildProcess and a MessageLoopForUI are both needed to fool the Tracks
   // and Sources in |registry_| into believing they are on the right threads.
   const base::MessageLoopForUI message_loop_;
   const ChildProcess child_process_;
   MockMediaStreamRegistry registry_;
 
+  // The Class under test. Needs to be scoped_ptr to force its destruction.
+  scoped_ptr<MediaRecorderHandler> media_recorder_handler_;
+
  private:
   DISALLOW_COPY_AND_ASSIGN(MediaRecorderHandlerTest);
 };
 
 // Checks that canSupportMimeType() works as expected.
 // TODO(mcasas): revisit this when canSupportMimeType() is fully implemented.
 TEST_F(MediaRecorderHandlerTest, CanSupportMimeType) {
   const WebString good_mime_type(base::UTF8ToUTF16("video/vp8"));
   EXPECT_TRUE(media_recorder_handler_->canSupportMimeType(good_mime_type));
 
@@ skipping 70 matching lines @@
   }
 
   media_recorder_handler_->stop();
 
   // Expect a last call on destruction, with size 0 and |lastInSlice| true.
   EXPECT_CALL(*this, writeData(nullptr, 0, true)).Times(1);
   media_recorder_handler_.reset();
 }
 
 }  // namespace content