use allocator (if present) when we allocate our cache bitmap

use allocator (if present) when we allocate our cache bitmap

Remove some bogus tests on the cache, as they are not thread-reliable. Running w/ discardable these are racy.

BUG=532981
Committed: https://skia.googlesource.com/skia/+/4b3d3bebda80be611ea79ec63a92d632c0375f20

[reed1, 2015-09-17 18:49:07]

reed@google.com changed reviewers:
+ fmalita@chromium.org, robertphillips@google.com, tomhudson@google.com

[tomhudson, 2015-09-17 18:58:07]

Why remove the old tests?

https://codereview.chromium.org/1351453004/diff/1/src/core/SkImageGenerator.cpp
File src/core/SkImageGenerator.cpp (right):

https://codereview.chromium.org/1351453004/diff/1/src/core/SkImageGenerator.c...
src/core/SkImageGenerator.cpp:159: ctStorage, &ctCount)) {
Do we need to reset the bitmap here?

https://codereview.chromium.org/1351453004/diff/1/src/core/SkImageGenerator.c...
src/core/SkImageGenerator.cpp:172: //           
ctable->dangerous_overwriteColors(ctStorage, ctCount);
Resolve commented-out code before landing.

https://codereview.chromium.org/1351453004/diff/1/src/core/SkResourceCache.cpp
File src/core/SkResourceCache.cpp (right):

https://codereview.chromium.org/1351453004/diff/1/src/core/SkResourceCache.cp...
src/core/SkResourceCache.cpp:22: #define SK_USE_DISCARDABLE_SCALEDIMAGECACHE
Don't you want to comment this back out? Or is it the new default for Skia?

[f(malita), 2015-09-17 19:42:07]

Nit: link to OOM bug.

[reed1, 2015-09-17 19:55:15]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-09-17 19:55:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1351453004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1351453004/20001

[reed1, 2015-09-17 19:57:23]

ptal

https://codereview.chromium.org/1351453004/diff/1/src/core/SkImageGenerator.cpp
File src/core/SkImageGenerator.cpp (right):

https://codereview.chromium.org/1351453004/diff/1/src/core/SkImageGenerator.c...
src/core/SkImageGenerator.cpp:159: ctStorage, &ctCount)) {
On 2015/09/17 18:58:07, tomhudson wrote:
> Do we need to reset the bitmap here?

Done.

https://codereview.chromium.org/1351453004/diff/1/src/core/SkImageGenerator.c...
src/core/SkImageGenerator.cpp:172: //           
ctable->dangerous_overwriteColors(ctStorage, ctCount);
On 2015/09/17 18:58:07, tomhudson wrote:
> Resolve commented-out code before landing.

Done.

https://codereview.chromium.org/1351453004/diff/1/src/core/SkResourceCache.cpp
File src/core/SkResourceCache.cpp (right):

https://codereview.chromium.org/1351453004/diff/1/src/core/SkResourceCache.cp...
src/core/SkResourceCache.cpp:22: #define SK_USE_DISCARDABLE_SCALEDIMAGECACHE
On 2015/09/17 18:58:07, tomhudson wrote:
> Don't you want to comment this back out? Or is it the new default for Skia?

Done.

[commit-bot: I haz the power, 2015-09-17 20:01:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-17 20:01:55]

Dry run: This issue passed the CQ dry run.

[tomhudson, 2015-09-17 20:16:35]

lgtm

[f(malita), 2015-09-17 20:16:46]

lgtm. hopefully we can clean up the colortable thing at some point.

[reed1, 2015-09-17 20:28:50]

The CQ bit was checked by reed@google.com

[reed1, 2015-09-17 20:28:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
fmalita@chromium.org, tomhudson@google.com
Link to the patchset: https://codereview.chromium.org/1351453004/#ps40001
(title: "fission out test change to separate CL")

[commit-bot: I haz the power, 2015-09-17 20:29:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1351453004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1351453004/40001

[reed1, 2015-09-17 20:29:09]

The CQ bit was unchecked by reed@google.com

[reed1, 2015-09-17 20:32:19]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2015-09-17 20:32:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1351453004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1351453004/40001

[commit-bot: I haz the power, 2015-09-17 20:35:23]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/4b3d3bebda80be611ea79ec63a92d632c0375f20