Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: content/renderer/media/media_permission_dispatcher.h

Issue 1351443005: Refactor media permission dispatcher class and create proxy class for non-UI threads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Base class for MediaPermission implementations in content. This class allows
6 // multiple pending PermissionService calls by managing callbacks for its
7 // subclasses. This class is not thread safe and should only be used on one
8 // thread.
9
5 #ifndef CONTENT_RENDERER_MEDIA_MEDIA_PERMISSION_DISPATCHER_H_ 10 #ifndef CONTENT_RENDERER_MEDIA_MEDIA_PERMISSION_DISPATCHER_H_
6 #define CONTENT_RENDERER_MEDIA_MEDIA_PERMISSION_DISPATCHER_H_ 11 #define CONTENT_RENDERER_MEDIA_MEDIA_PERMISSION_DISPATCHER_H_
7 12
8 #include <map> 13 #include <map>
9 14
15 #include "base/memory/weak_ptr.h"
10 #include "base/threading/thread_checker.h" 16 #include "base/threading/thread_checker.h"
11 #include "content/common/content_export.h"
12 #include "content/common/permission_service.mojom.h"
13 #include "content/public/renderer/render_frame_observer.h"
14 #include "media/base/media_permission.h" 17 #include "media/base/media_permission.h"
15 18
16 namespace content { 19 namespace content {
17 20
18 // MediaPermission implementation in content. This class is not thread safe 21 class MediaPermissionDispatcher : public media::MediaPermission {
19 // and should only be used on one thread.
20 class CONTENT_EXPORT MediaPermissionDispatcher : public media::MediaPermission,
21 public RenderFrameObserver {
22 public: 22 public:
23 explicit MediaPermissionDispatcher(RenderFrame* render_frame); 23 MediaPermissionDispatcher();
24 ~MediaPermissionDispatcher() override; 24 ~MediaPermissionDispatcher() override;
25 25
26 // media::MediaPermission implementation. 26 protected:
27 void HasPermission(Type type, 27 // Register callbacks for PermissionService calls.
28 const GURL& security_origin, 28 uint32_t RegisterCallback(const PermissionStatusCB& permission_status_cb);
29 const PermissionStatusCB& permission_status_cb) override; 29
30 void RequestPermission( 30 // Deliver the permission status |granted| to the callback identified by
31 Type type, 31 // |request_id|.
32 const GURL& security_origin, 32 void DeliverResult(uint32_t request_id, bool granted);
33 const PermissionStatusCB& permission_status_cb) override; 33
34 base::ThreadChecker& thread_checker() { return thread_checker_; }
34 35
35 private: 36 private:
36 // Map of request IDs and pending PermissionStatusCBs. 37 // Map of request IDs and pending PermissionStatusCBs.
37 typedef std::map<uint32_t, PermissionStatusCB> RequestMap; 38 typedef std::map<uint32_t, PermissionStatusCB> RequestMap;
38 39
39 // Callback for |permission_service_| calls. 40 base::ThreadChecker thread_checker_;
40 void OnPermissionStatus(uint32_t request_id, PermissionStatus status);
41 41
42 uint32_t next_request_id_; 42 uint32_t next_request_id_;
43 RequestMap requests_; 43 RequestMap requests_;
44 PermissionServicePtr permission_service_;
45
46 base::ThreadChecker thread_checker_;
47 44
48 DISALLOW_COPY_AND_ASSIGN(MediaPermissionDispatcher); 45 DISALLOW_COPY_AND_ASSIGN(MediaPermissionDispatcher);
49 }; 46 };
50 47
51 } // namespace content 48 } // namespace content
52 49
53 #endif // CONTENT_RENDERER_MEDIA_MEDIA_PERMISSION_DISPATCHER_H_ 50 #endif // CONTENT_RENDERER_MEDIA_MEDIA_PERMISSION_DISPATCHER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698