Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: mojo/shell/application_manager_unittest.cc

Issue 1351443004: Revert of Make CapabilityFilter be part of Identity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/shell/application_manager.cc ('k') | mojo/shell/capability_filter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/application_manager_unittest.cc
diff --git a/mojo/shell/application_manager_unittest.cc b/mojo/shell/application_manager_unittest.cc
index bc4e2daf6b108c1f0c12e8fe9efd35cedbb7248e..8cc0456236a4cca79976c25cd077e0402bdc86a1 100644
--- a/mojo/shell/application_manager_unittest.cc
+++ b/mojo/shell/application_manager_unittest.cc
@@ -687,7 +687,8 @@
bool called = false;
scoped_ptr<ConnectToApplicationParams> params(new ConnectToApplicationParams);
- params->SetTargetURL(GURL("test:test"));
+ params->SetURLInfo(GURL("test:test"));
+ params->set_filter(GetPermissiveCapabilityFilter());
params->set_on_application_end(
base::Bind(&QuitClosure, base::Unretained(&called)));
application_manager_->ConnectToApplication(params.Pass());
@@ -715,8 +716,10 @@
bool called = false;
scoped_ptr<ConnectToApplicationParams> params(new ConnectToApplicationParams);
- params->set_source(Identity(requestor_url));
- params->SetTargetURL(GURL("test:test"));
+ params->set_originator_identity(Identity(requestor_url));
+ params->set_originator_filter(GetPermissiveCapabilityFilter());
+ params->SetURLInfo(GURL("test:test"));
+ params->set_filter(GetPermissiveCapabilityFilter());
params->set_on_application_end(
base::Bind(&QuitClosure, base::Unretained(&called)));
application_manager.ConnectToApplication(params.Pass());
@@ -785,8 +788,10 @@
base::RunLoop run_loop;
scoped_ptr<ConnectToApplicationParams> params(
new ConnectToApplicationParams);
- params->set_source(Identity(requestor_url));
- params->SetTargetURL(GURL("test:test"));
+ params->set_originator_identity(Identity(requestor_url));
+ params->set_originator_filter(GetPermissiveCapabilityFilter());
+ params->SetURLInfo(GURL("test:test"));
+ params->set_filter(GetPermissiveCapabilityFilter());
params->set_connect_callback([&content_handler_id, &run_loop](uint32_t t) {
content_handler_id = t;
run_loop.Quit();
@@ -801,8 +806,10 @@
base::RunLoop run_loop;
scoped_ptr<ConnectToApplicationParams> params(
new ConnectToApplicationParams);
- params->set_source(Identity(requestor_url));
- params->SetTargetURL(GURL("test:test"));
+ params->set_originator_identity(Identity(requestor_url));
+ params->set_originator_filter(GetPermissiveCapabilityFilter());
+ params->SetURLInfo(GURL("test:test"));
+ params->set_filter(GetPermissiveCapabilityFilter());
params->set_connect_callback([&content_handler_id2, &run_loop](uint32_t t) {
content_handler_id2 = t;
run_loop.Quit();
@@ -839,8 +846,10 @@
base::RunLoop run_loop;
scoped_ptr<ConnectToApplicationParams> params(
new ConnectToApplicationParams);
- params->set_source(Identity(requestor_url));
- params->SetTargetURL(GURL("test:test"));
+ params->set_originator_identity(Identity(requestor_url));
+ params->set_originator_filter(GetPermissiveCapabilityFilter());
+ params->SetURLInfo(GURL("test:test"));
+ params->set_filter(GetPermissiveCapabilityFilter());
params->set_connect_callback([&content_handler_id, &run_loop](uint32_t t) {
content_handler_id = t;
run_loop.Quit();
@@ -869,8 +878,10 @@
base::RunLoop run_loop;
scoped_ptr<ConnectToApplicationParams> params(
new ConnectToApplicationParams);
- params->set_source(Identity(requestor_url));
- params->SetTargetURL(GURL("test2:test2"));
+ params->set_originator_identity(Identity(requestor_url));
+ params->set_originator_filter(GetPermissiveCapabilityFilter());
+ params->SetURLInfo(GURL("test2:test2"));
+ params->set_filter(GetPermissiveCapabilityFilter());
params->set_connect_callback([&content_handler_id2, &run_loop](uint32_t t) {
content_handler_id2 = t;
run_loop.Quit();
@@ -890,7 +901,8 @@
uint32_t content_handler_id = 1u;
scoped_ptr<ConnectToApplicationParams> params(new ConnectToApplicationParams);
- params->SetTargetURL(GURL("test:test"));
+ params->SetURLInfo(GURL("test:test"));
+ params->set_filter(GetPermissiveCapabilityFilter());
params->set_connect_callback(
[&content_handler_id](uint32_t t) { content_handler_id = t; });
application_manager_->ConnectToApplication(params.Pass());
« no previous file with comments | « mojo/shell/application_manager.cc ('k') | mojo/shell/capability_filter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698