Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 1351443004: Revert of Make CapabilityFilter be part of Identity (Closed)

Created:
5 years, 3 months ago by vabr (Chromium)
Modified:
5 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make CapabilityFilter be part of Identity (patchset #15 id:280001 of https://codereview.chromium.org/1354003002/ ) Reason for revert: Reverting for test breakage, more info on the bug. BUG=534227 Original issue's description: > Make CapabilityFilter be part of Identity > > R=yzshen@chromium.org > http://crbug.com/533085 > > Committed: https://crrev.com/5403e28c9d9bfcf00b12721b6dc96c00f6d1ed24 > Cr-Commit-Position: refs/heads/master@{#349815} TBR=yzshen@chromium.org,ben@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/3cc08430d1ec58b37e9136d5dda3462397a250d2 Cr-Commit-Position: refs/heads/master@{#349907}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -199 lines) Patch
M content/browser/mojo/mojo_shell_context.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/fetcher/about_fetcher_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/runner/context.cc View 3 chunks +12 lines, -4 lines 0 comments Download
M mojo/runner/native_runner_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/runner/shell_test_base.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M mojo/shell/application_instance.h View 3 chunks +6 lines, -1 line 0 comments Download
M mojo/shell/application_instance.cc View 6 chunks +38 lines, -19 lines 0 comments Download
M mojo/shell/application_manager.h View 1 chunk +5 lines, -2 lines 0 comments Download
M mojo/shell/application_manager.cc View 8 chunks +41 lines, -27 lines 0 comments Download
M mojo/shell/application_manager_unittest.cc View 7 chunks +24 lines, -12 lines 0 comments Download
M mojo/shell/capability_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/capability_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/capability_filter_unittest.cc View 1 chunk +5 lines, -1 line 0 comments Download
M mojo/shell/connect_to_application_params.h View 4 chunks +40 lines, -21 lines 0 comments Download
M mojo/shell/connect_to_application_params.cc View 1 chunk +14 lines, -25 lines 0 comments Download
M mojo/shell/connect_util.h View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/shell/connect_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/content_handler_connection.h View 2 chunks +13 lines, -6 lines 0 comments Download
M mojo/shell/content_handler_connection.cc View 1 chunk +13 lines, -5 lines 0 comments Download
M mojo/shell/identity.h View 2 chunks +5 lines, -23 lines 0 comments Download
M mojo/shell/identity.cc View 1 chunk +9 lines, -39 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
vabr (Chromium)
Created Revert of Make CapabilityFilter be part of Identity
5 years, 3 months ago (2015-09-21 06:58:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351443004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351443004/1
5 years, 3 months ago (2015-09-21 06:58:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-21 06:59:01 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 06:59:39 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3cc08430d1ec58b37e9136d5dda3462397a250d2
Cr-Commit-Position: refs/heads/master@{#349907}

Powered by Google App Engine
This is Rietveld 408576698