Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1351413002: DevTools: remove padding before pseudo-element matched styles. (Closed)

Created:
5 years, 3 months ago by lushnikov
Modified:
5 years, 3 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

DevTools: remove padding before pseudo-element matched styles. After the "Toggle Element State" buttons moved away from Styles Sidebar Pane layout, we no longer need the padding. R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202600

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M Source/devtools/front_end/elements/StylesSidebarPane.js View 2 chunks +0 lines, -10 lines 0 comments Download
M Source/devtools/front_end/elements/elementsPanel.css View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
lushnikov
ptal
5 years, 3 months ago (2015-09-18 21:40:43 UTC) #1
pfeldman
screenshot please
5 years, 3 months ago (2015-09-19 00:03:52 UTC) #2
lushnikov
before: http://imgur.com/3jGbma1 after: http://imgur.com/xTmV77Q
5 years, 3 months ago (2015-09-21 17:48:36 UTC) #3
pfeldman
lgtm
5 years, 3 months ago (2015-09-21 17:50:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351413002/1
5 years, 3 months ago (2015-09-21 17:54:19 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 20:01:52 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202600

Powered by Google App Engine
This is Rietveld 408576698