Issue 1351403005: try simplest code: inline whenever vaguely sensible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1351403005: try simplest code: inline whenever vaguely sensible (Closed)

Created:
5 years, 3 months ago by mtklein_C

Modified:
5 years, 1 month ago

Reviewers:
mtklein, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

try simplest code: inline whenever vaguely sensible BUG=skia:4316 Will land and revert. TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/527a0c8235b454f5d0475a9a3e34caa9520db3a2

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -10 lines)			Patch
	M	include/core/SkUtils.h	View		2 chunks	+8 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351403005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351403005/1

5 years, 3 months ago (2015-09-21 01:59:45 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/527a0c8235b454f5d0475a9a3e34caa9520db3a2

5 years, 3 months ago (2015-09-21 02:04:25 UTC) #3

mtklein

5 years, 3 months ago (2015-09-21 02:04:52 UTC) #4

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1355073002/ by mtklein@google.com.

The reason for reverting is: pingpong.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages