Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Unified Diff: Source/core/layout/LayoutTable.cpp

Issue 1351383006: Remove unused variable movedSectionLogicalTop from table layout code. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/LayoutTable.cpp
diff --git a/Source/core/layout/LayoutTable.cpp b/Source/core/layout/LayoutTable.cpp
index 1e52da8b5f249c922a66e00a60d2b8800642e02e..7c2d93c430b137b2dd321e4d7d5b62279b97195b 100644
--- a/Source/core/layout/LayoutTable.cpp
+++ b/Source/core/layout/LayoutTable.cpp
@@ -437,7 +437,6 @@ void LayoutTable::layout()
// section down (it is quite unlikely that any of the following sections
// did not shift).
bool sectionMoved = false;
- LayoutUnit movedSectionLogicalTop = 0;
{
LayoutState state(*this, locationOffset());
LayoutUnit oldLogicalWidth = logicalWidth();
@@ -494,10 +493,7 @@ void LayoutTable::layout()
continue;
layoutCaption(*m_captions[i]);
}
- if (logicalHeight() != oldTableLogicalTop) {
- sectionMoved = true;
- movedSectionLogicalTop = std::min(logicalHeight(), oldTableLogicalTop);
- }
+ sectionMoved = logicalHeight() != oldTableLogicalTop;
}
LayoutUnit borderAndPaddingBefore = borderBefore() + (collapsing ? LayoutUnit() : paddingBefore());
@@ -541,10 +537,8 @@ void LayoutTable::layout()
// position the table sections
LayoutTableSection* section = topSection();
while (section) {
- if (!sectionMoved && section->logicalTop() != logicalHeight()) {
+ if (!sectionMoved && section->logicalTop() != logicalHeight())
sectionMoved = true;
- movedSectionLogicalTop = std::min(logicalHeight(), section->logicalTop()) + (style()->isHorizontalWritingMode() ? section->visualOverflowRect().y() : section->visualOverflowRect().x());
- }
section->setLogicalLocation(LayoutPoint(sectionLogicalLeft, logicalHeight()));
// As we may skip invalidation on the table, we need to ensure that sections are invalidated when they moved.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698