Chromium Code Reviews| Index: fpdfsdk/src/javascript/JS_Object.cpp |
| diff --git a/fpdfsdk/src/javascript/JS_Object.cpp b/fpdfsdk/src/javascript/JS_Object.cpp |
| index 6891e6fc606d55818f04c97a09a1cf25eb6b2d65..3de7c921fd12493fab011b8d2dca4598079cc128 100644 |
| --- a/fpdfsdk/src/javascript/JS_Object.cpp |
| +++ b/fpdfsdk/src/javascript/JS_Object.cpp |
| @@ -83,15 +83,15 @@ void DisposeObject(const v8::WeakCallbackInfo<CJS_Object>& data) { |
| data.SetSecondPassCallback(FreeObject); |
| } |
| -CJS_Object::CJS_Object(v8::Local<v8::Object> pObject) : m_pEmbedObj(NULL) { |
| +CJS_Object::CJS_Object(v8::Local<v8::Object> pObject) { |
| v8::Local<v8::Context> context = pObject->CreationContext(); |
| m_pIsolate = context->GetIsolate(); |
| m_pObject.Reset(m_pIsolate, pObject); |
| -}; |
| +} |
| CJS_Object::~CJS_Object() { |
| m_pObject.Reset(); |
|
Tom Sepez
2015/09/18 23:29:32
Do we even have to do this? This member is a v8::
Lei Zhang
2015/09/18 23:51:51
Don't think so. Note, this is a v8::Global, but ~G
|
| -}; |
| +} |
| void CJS_Object::MakeWeak() { |
| m_pObject.SetWeak(this, DisposeObject, v8::WeakCallbackType::kInternalFields); |