Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1351323002: ppapi: AudioEncode: drop Speex codec (Closed)

Created:
5 years, 3 months ago by llandwerlin-old
Modified:
5 years, 3 months ago
Reviewers:
bbudge
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, teravest+watch_chromium.org, bradnelson+warch_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ppapi: AudioEncode: drop Speex codec Speex was removed from the chromium third party dependencies. Since Opus was designed as a replacement for Speex, let's just drop Speex from the pepper api. BUG=461222 Committed: https://crrev.com/e982d804c531dd3f628de3f75e96db92b93ab7a8 Cr-Commit-Position: refs/heads/master@{#349658}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M ppapi/api/pp_codecs.idl View 1 chunk +1 line, -2 lines 0 comments Download
M ppapi/c/pp_codecs.h View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
llandwerlin-old
bbudge@: PTAL, thanks.
5 years, 3 months ago (2015-09-18 09:46:55 UTC) #2
bbudge
lgtm
5 years, 3 months ago (2015-09-18 13:20:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351323002/1
5 years, 3 months ago (2015-09-18 13:22:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-18 13:33:44 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 13:34:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e982d804c531dd3f628de3f75e96db92b93ab7a8
Cr-Commit-Position: refs/heads/master@{#349658}

Powered by Google App Engine
This is Rietveld 408576698