Issue 135123008: replace impl of SkLightingColorFilter with SkColorMatrixFilter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 135123008: replace impl of SkLightingColorFilter with SkColorMatrixFilter (Closed)

Created:
6 years, 10 months ago by reed1

Modified:
6 years, 10 months ago

Reviewers:
djsollen

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

replace impl of SkLightingColorFilter with SkColorMatrixFilter BUG=skia: R=djsollen@google.com Committed: https://code.google.com/p/skia/source/detail?r=13350

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -39 lines)			Patch
M	include/effects/SkColorMatrix.h	View	1	2 chunks	+14 lines, -0 lines	0 comments	Download
M	src/effects/SkColorFilters.cpp	View	1	7 chunks	+34 lines, -4 lines	0 comments	Download
M	src/effects/SkColorMatrix.cpp	View	1	4 chunks	+22 lines, -19 lines	0 comments	Download
M	src/effects/SkColorMatrixFilter.cpp	View	1	6 chunks	+18 lines, -16 lines	0 comments	Download

Total messages: 4 (0 generated)

reed1

6 years, 10 months ago (2014-02-06 20:59:53 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r13350 (presubmit successful).