chrome/browser/extensions/installed_loader.cc - Issue 1351223003: Allow extensions to specify that they are not allowed in incognito mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/installed_loader.cc

Issue 1351223003: Allow extensions to specify that they are not allowed in incognito mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add expectations for IncognitoInfo to test Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/installed_loader.cc

diff --git a/chrome/browser/extensions/installed_loader.cc b/chrome/browser/extensions/installed_loader.cc

index 9d562c44f0559078e12a74cd3c9683864bd62ed5..8ee9a02b32a4e57d932d7632c38820144ec3662a 100644

--- a/chrome/browser/extensions/installed_loader.cc

+++ b/chrome/browser/extensions/installed_loader.cc

@@ -28,6 +28,7 @@

#include "extensions/browser/extension_prefs.h"

#include "extensions/browser/extension_registry.h"

#include "extensions/browser/extension_system.h"

+#include "extensions/browser/extension_util.h"

#include "extensions/browser/management_policy.h"

#include "extensions/common/extension.h"

#include "extensions/common/extension_l10n_util.h"

@@ -511,7 +512,7 @@ void InstalledLoader::RecordExtensionsMetrics() {

// extensions are boring.

if (extension->ShouldDisplayInExtensionSettings() &&

!Manifest::IsPolicyLocation(extension->location())) {

- if (extension->can_be_incognito_enabled()) {

+ if (util::CanBeIncognitoEnabled(extension)) {

if (util::IsIncognitoEnabled(extension->id(), profile))

++incognito_allowed_count;

else

« no previous file with comments | « chrome/browser/extensions/extension_util.cc ('k') | extensions/browser/extension_util.h » ('j') | no next file with comments »