Allow extensions to specify that they are not allowed in incognito mode.

extensions/common/extension.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/extension.h"
 
 #include "base/base64.h"
 #include "base/basictypes.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
@@ skipping 10 matching lines @@
 #include "base/values.h"
 #include "base/version.h"
 #include "components/crx_file/id_util.h"
 #include "content/public/common/url_constants.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/error_utils.h"
 #include "extensions/common/feature_switch.h"
 #include "extensions/common/manifest.h"
 #include "extensions/common/manifest_constants.h"
 #include "extensions/common/manifest_handler.h"
+#include "extensions/common/manifest_handlers/incognito_info.h"
 #include "extensions/common/manifest_handlers/permissions_parser.h"
 #include "extensions/common/permissions/permission_set.h"
 #include "extensions/common/permissions/permissions_data.h"
 #include "extensions/common/permissions/permissions_info.h"
 #include "extensions/common/switches.h"
 #include "extensions/common/url_pattern.h"
 #include "net/base/filename_util.h"
 #include "url/url_util.h"
 
 namespace extensions {
@@ skipping 392 matching lines @@
 bool Extension::is_shared_module() const {
   return manifest()->is_shared_module();
 }
 
 bool Extension::is_theme() const {
   return manifest()->is_theme();
 }
 
 bool Extension::can_be_incognito_enabled() const {
   // Only component platform apps are supported in incognito.
-  return !is_platform_app() || location() == Manifest::COMPONENT;
+  return IncognitoInfo::IsIncognitoAllowed(this) &&

[not at google - send to devlin, 2015/09/17 22:59:54]

This function has too much logic, especially for one called
can_be_incognito_enabled (supposed to be reserved for simple accessors). Let's
move this to... extension_util.h maybe (in /extensions), as
CanBeIncognitoEnabled, to mirror the IsIncognitoEnabled function (in /chrome).

[Not at Google. Contact bengr, 2015/09/18 21:24:31]

Done.

+         (!is_platform_app() || location() == Manifest::COMPONENT);
 }
 
 void Extension::AddWebExtentPattern(const URLPattern& pattern) {
   // Bookmark apps are permissionless.
   if (from_bookmark())
     return;
 
   extent_.AddPattern(pattern);
 }
 
@@ skipping 331 matching lines @@
 
 UpdatedExtensionPermissionsInfo::UpdatedExtensionPermissionsInfo(
     const Extension* extension,
     const PermissionSet* permissions,
     Reason reason)
     : reason(reason),
       extension(extension),
       permissions(permissions) {}
 
 }   // namespace extensions