Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1351203002: Make deps of GN groups public. (Closed)

Created:
5 years, 3 months ago by brettw
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews-bindings_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make deps of GN groups public. Theses are implicitly public today, but I'm going to remove some transitional code that will change the default to be private. This change should be a No-Op with today's GN behavior. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202488

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M Source/bindings/modules/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/modules/v8/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M public/BUILD.gn View 5 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
brettw
5 years, 3 months ago (2015-09-17 22:27:13 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351203002/1
5 years, 3 months ago (2015-09-17 22:27:34 UTC) #4
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-17 23:12:13 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-17 23:31:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351203002/1
5 years, 3 months ago (2015-09-18 01:15:15 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 01:21:25 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202488

Powered by Google App Engine
This is Rietveld 408576698