fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp - Issue 1351173002: XFA: contention between FXJSE and FXJS over isolate data slots

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp

Issue 1351173002: XFA: contention between FXJSE and FXJS over isolate data slots (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp

diff --git a/fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp b/fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp

index 827e96365a65249310ac6abe6c8e17960cad784e..7f65badd9d39ad2c5f1583ab1256159c716b4199 100644

--- a/fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp

+++ b/fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp

@@ -32,7 +32,7 @@ class FXJSV8Embeddertest : public EmbedderTest {

v8::Locker locker(m_pIsolate);

v8::HandleScope handle_scope(m_pIsolate);

FXJS_Initialize(0);

- FXJS_PrepareIsolate(m_pIsolate);

+ FXJS_PerIsolateData::SetUp(m_pIsolate);

FXJS_InitializeRuntime(m_pIsolate, nullptr, nullptr, m_pPersistentContext);

}

« no previous file with comments | « fpdfsdk/src/jsapi/fxjs_v8.cpp ('k') | xfa/src/fxjse/src/runtime.cpp » ('j') | xfa/src/fxjse/src/runtime.cpp » ('J')