XFA: contention between FXJSE and FXJS over isolate data slots

fpdfsdk/src/fsdk_mgr.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../public/fpdf_ext.h"
 #include "../include/fsdk_define.h"
 #include "../include/fpdfxfa/fpdfxfa_doc.h"
 #include "../include/fpdfxfa/fpdfxfa_page.h"
@@ skipping 207 matching lines @@
 }
 
 CPDFDoc_Environment::~CPDFDoc_Environment() {
   delete m_pIFormFiller;
   m_pIFormFiller = NULL;
 
   CPDFXFA_App* pProvider = CPDFXFA_App::GetInstance();
   if (m_pJSRuntime && pProvider->GetRuntimeFactory())
     pProvider->GetRuntimeFactory()->DeleteJSRuntime(m_pJSRuntime);
 
-  if (pProvider->m_pEnvList.GetSize() == 0) {
-    pProvider->ReleaseRuntime();
-    pProvider->InitRuntime(TRUE);
-  }
+  if (pProvider->m_pEnvList.GetSize() == 0)
+    pProvider->SetJavaScriptInitialized(FALSE);
 
   delete m_pSysHandler;
   m_pSysHandler = NULL;
 
   delete m_pAnnotHandlerMgr;
   m_pAnnotHandlerMgr = NULL;
 
   delete m_pActionHandler;
   m_pActionHandler = NULL;
 }
@@ skipping 953 matching lines @@
   if (!pFocusAnnot)
     return NULL;
 
   for (int i = 0; i < m_fxAnnotArray.GetSize(); i++) {
     CPDFSDK_Annot* pAnnot = (CPDFSDK_Annot*)m_fxAnnotArray.GetAt(i);
     if (pAnnot == pFocusAnnot)
       return pAnnot;
   }
   return NULL;
 }