XFA: contention between FXJSE and FXJS over isolate data slots

fpdfsdk/include/fpdfxfa/fpdfxfa_app.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef FPDFXFA_APP_H_
 #define FPDFXFA_APP_H_
 
 class IFXJS_Runtime;
 class CJS_RuntimeFactory;
 
 class CPDFXFA_App : public IXFA_AppProvider {
  public:
   static CPDFXFA_App* GetInstance();
   static void ReleaseInstance();
 
   CPDFXFA_App();
   ~CPDFXFA_App() override;
 
   FX_BOOL Initialize();
   IXFA_App* GetXFAApp() { return m_pXFAApp; }
 
   FX_BOOL AddFormFillEnv(CPDFDoc_Environment* pEnv);
   FX_BOOL RemoveFormFillEnv(CPDFDoc_Environment* pEnv);
 
-  FXJSE_HRUNTIME GetJSERuntime() { return m_hJSERuntime; }
-  void ReleaseRuntime();
-  FX_BOOL InitRuntime(FX_BOOL bReset = FALSE);
+  FX_BOOL IsJavaScriptInitialized() const { return m_bJavaScriptInitialized; }
+  void SetJavaScriptInitialized(FX_BOOL bInitialized) {
+    m_bJavaScriptInitialized = bInitialized;
+  }
 
-  CJS_RuntimeFactory* GetRuntimeFactory() { return m_pJSRuntimeFactory; }
+  FXJSE_HRUNTIME GetJSERuntime() const { return m_hJSERuntime; }
+  CJS_RuntimeFactory* GetRuntimeFactory() const { return m_pJSRuntimeFactory; }
 
   // IFXA_AppProvider:
   void GetAppType(CFX_WideString& wsAppType) override;
   void SetAppType(const CFX_WideStringC& wsAppType) override;
 
   void GetLanguage(CFX_WideString& wsLanguage) override;
   void GetPlatform(CFX_WideString& wsPlatform) override;
   void GetVariation(CFX_WideString& wsVariation) override;
   void GetVersion(CFX_WideString& wsVersion) override;
   void GetFoxitVersion(CFX_WideString& wsFoxitVersion) override {
@@ skipping 35 matching lines @@
                          const CFX_WideStringC& wsFilter,
                          CFX_WideStringArray& wsPathArr,
                          FX_BOOL bOpen) override;
   IFWL_AdapterTimerMgr* GetTimerMgr() override;
 
   CFX_ArrayTemplate<CPDFDoc_Environment*> m_pEnvList;
 
  protected:
   static CPDFXFA_App* g_pApp;
 
-  FX_BOOL m_bInitRuntime;
+  FX_BOOL m_bJavaScriptInitialized;
   IXFA_App* m_pXFAApp;
   IXFA_FontMgr* m_pFontMgr;
   FXJSE_HRUNTIME m_hJSERuntime;
   IFXJS_Runtime* m_pJSRuntime;
   CJS_RuntimeFactory* m_pJSRuntimeFactory;
   CFX_WideString m_csAppType;
 };
 
 #endif  // FPDFXFA_APP_H_