Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: src/IceInstX86Base.h

Issue 1351133003: Optimize 64-bit shifts by constants for x86-32 (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Code review updates Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceInstX86Base.h
diff --git a/src/IceInstX86Base.h b/src/IceInstX86Base.h
index 5ca94221072bbfefa49c5ccd0197ad0b77157d1f..9b0b5fc72e8e439f07e656bb2c5adcceb61ebf25 100644
--- a/src/IceInstX86Base.h
+++ b/src/IceInstX86Base.h
@@ -2103,7 +2103,7 @@ template <class Machine> class InstX86Shld final : public InstX86Base<Machine> {
public:
static InstX86Shld *create(Cfg *Func, Variable *Dest, Variable *Source1,
- Variable *Source2) {
+ Operand *Source2) {
return new (Func->allocate<InstX86Shld>())
InstX86Shld(Func, Dest, Source1, Source2);
}
@@ -2115,7 +2115,7 @@ public:
}
private:
- InstX86Shld(Cfg *Func, Variable *Dest, Variable *Source1, Variable *Source2);
+ InstX86Shld(Cfg *Func, Variable *Dest, Variable *Source1, Operand *Source2);
};
/// Shrd instruction - shift across a pair of operands.
@@ -2126,7 +2126,7 @@ template <class Machine> class InstX86Shrd final : public InstX86Base<Machine> {
public:
static InstX86Shrd *create(Cfg *Func, Variable *Dest, Variable *Source1,
- Variable *Source2) {
+ Operand *Source2) {
return new (Func->allocate<InstX86Shrd>())
InstX86Shrd(Func, Dest, Source1, Source2);
}
@@ -2138,7 +2138,7 @@ public:
}
private:
- InstX86Shrd(Cfg *Func, Variable *Dest, Variable *Source1, Variable *Source2);
+ InstX86Shrd(Cfg *Func, Variable *Dest, Variable *Source1, Operand *Source2);
};
/// Conditional move instruction.

Powered by Google App Engine
This is Rietveld 408576698