Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1351133002: Revert of Add flags to python test server for channel id, extended master secret, and token binding (Closed)

Created:
5 years, 3 months ago by tommycli
Modified:
5 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add flags to python test server for channel id, extended master secret, and token binding (patchset #2 id:20001 of https://codereview.chromium.org/1347503002/ ) Reason for revert: This change tripped the Linux Tests (valgrind) memory bots. See: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20(valgrind)(1) First failure: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%281%29/builds/43655 Cause: Newly added member variables are not initialized in second constructor. Thanks and sorry for revert. Original issue's description: > Add flags to python test server for channel id, extended master secret, and token binding > > BUG=467312 > > Committed: https://crrev.com/22e67634e17914c5dddc6ad2649a4bf701908311 > Cr-Commit-Position: refs/heads/master@{#349164} TBR=davidben@chromium.org,rsleevi@chromium.org,nharper@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=467312 Committed: https://crrev.com/13f982af192e9fecd145500670198adc515d4429 Cr-Commit-Position: refs/heads/master@{#349439}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -50 lines) Patch
M net/test/spawned_test_server/base_test_server.h View 1 chunk +0 lines, -9 lines 0 comments Download
M net/test/spawned_test_server/base_test_server.cc View 3 chunks +2 lines, -24 lines 0 comments Download
M net/tools/testserver/testserver.py View 4 chunks +2 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tommycli
Created Revert of Add flags to python test server for channel id, extended master secret, ...
5 years, 3 months ago (2015-09-17 17:25:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351133002/1
5 years, 3 months ago (2015-09-17 17:26:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-17 17:27:28 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 17:28:10 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/13f982af192e9fecd145500670198adc515d4429
Cr-Commit-Position: refs/heads/master@{#349439}

Powered by Google App Engine
This is Rietveld 408576698