Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1581)

Issue 135113003: Revert 244229 "base: Fix registering of memory pressure listener..." (Closed)

Created:
6 years, 11 months ago by reveman
Modified:
6 years, 11 months ago
Reviewers:
reveman
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 244229 "base: Fix registering of memory pressure listener..." Causing webkit_unit_tests to fail. > base: Fix registering of memory pressure listeners used when emulating discardable memory. > > Memory pressure listeners need to be created on a thread with a message > loop current. Discardable memory is often used on worker threads that > don't have a message loop and with the current system where listeners > are registered on first use, the result is that we're most likely never > notified of memory pressure. > > This adds a function to the discardable memory interface that allows us > to register memory pressure listeners on a thread, and at a time, when > we know a message loop is current. > > BUG=332570 > TBR=jamesr@chromium.org > > Review URL: https://codereview.chromium.org/129963002 TBR=reveman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244278

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -124 lines) Patch
M trunk/src/base/memory/discardable_memory.h View 1 chunk +0 lines, -8 lines 0 comments Download
M trunk/src/base/memory/discardable_memory_android.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M trunk/src/base/memory/discardable_memory_emulated.h View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/base/memory/discardable_memory_emulated.cc View 2 chunks +5 lines, -15 lines 0 comments Download
M trunk/src/base/memory/discardable_memory_linux.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M trunk/src/base/memory/discardable_memory_mac.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M trunk/src/base/memory/discardable_memory_provider.h View 3 chunks +2 lines, -9 lines 0 comments Download
M trunk/src/base/memory/discardable_memory_provider.cc View 4 chunks +15 lines, -31 lines 0 comments Download
M trunk/src/base/memory/discardable_memory_provider_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/base/memory/discardable_memory_unittest.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M trunk/src/base/memory/discardable_memory_win.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M trunk/src/content/renderer/render_thread_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
reveman
6 years, 11 months ago (2014-01-11 00:07:50 UTC) #1
reveman
6 years, 11 months ago (2014-01-11 00:08:21 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r244278.

Powered by Google App Engine
This is Rietveld 408576698