 Chromium Code Reviews
 Chromium Code Reviews Issue 1351093002:
  [test] Switch perf try wrapper to buildbucket.  (Closed) 
  Base URL: https://chromium.googlesource.com/v8/v8.git@master
    
  
    Issue 1351093002:
  [test] Switch perf try wrapper to buildbucket.  (Closed) 
  Base URL: https://chromium.googlesource.com/v8/v8.git@master| Index: tools/try_perf.py | 
| diff --git a/tools/try_perf.py b/tools/try_perf.py | 
| index 5969ff003222effb1c173e3c280b6f64982c430c..f05baef8ce5dc238f3ef39e826b0028c5ceaf906 100755 | 
| --- a/tools/try_perf.py | 
| +++ b/tools/try_perf.py | 
| @@ -4,13 +4,10 @@ | 
| # found in the LICENSE file. | 
| import argparse | 
| -import find_depot_tools | 
| +import os | 
| +import subprocess | 
| import sys | 
| -find_depot_tools.add_depot_tools_to_path() | 
| - | 
| -from git_cl import Changelist | 
| - | 
| BOTS = { | 
| '--arm32': 'v8_arm32_perf_try', | 
| '--linux32': 'v8_linux32_perf_try', | 
| @@ -23,10 +20,14 @@ BOTS = { | 
| } | 
| DEFAULT_BOTS = [ | 
| + 'v8_arm32_perf_try', | 
| 'v8_linux32_perf_try', | 
| 'v8_linux64_haswell_perf_try', | 
| + 'v8_nexus10_perf_try', | 
| ] | 
| +V8_BASE = os.path.abspath(os.path.dirname(os.path.dirname(__file__))) | 
| + | 
| def main(): | 
| parser = argparse.ArgumentParser(description='') | 
| parser.add_argument("benchmarks", nargs="+", help="The benchmarks to run.") | 
| @@ -39,31 +40,20 @@ def main(): | 
| print 'No trybots specified. Using default %s.' % ','.join(DEFAULT_BOTS) | 
| options.bots = DEFAULT_BOTS | 
| - cl = Changelist() | 
| - if not cl.GetIssue(): | 
| - print 'Need to upload first' | 
| - return 1 | 
| - | 
| - props = cl.GetIssueProperties() | 
| - if props.get('closed'): | 
| - print 'Cannot send tryjobs for a closed CL' | 
| - return 1 | 
| - | 
| - if props.get('private'): | 
| - print 'Cannot use trybots with private issue' | 
| - return 1 | 
| - | 
| if not options.benchmarks: | 
| print 'Please specify the benchmarks to run as arguments.' | 
| return 1 | 
| - masters = { | 
| - 'internal.client.v8': dict((b, options.benchmarks) for b in options.bots), | 
| - } | 
| - cl.RpcServer().trigger_distributed_try_jobs( | 
| - cl.GetIssue(), cl.GetMostRecentPatchset(), cl.GetBranch(), | 
| - False, None, masters) | 
| - return 0 | 
| + # Ensure depot_tools are updated. | 
| 
tandrii(chromium)
2015/09/17 12:45:21
nice!
 | 
| + subprocess.check_output( | 
| + 'gclient', shell=True, stderr=subprocess.STDOUT, cwd=V8_BASE) | 
| + | 
| + cmd = ['git cl try -m internal.client.v8'] | 
| + cmd += ['-b %s' % bot for bot in options.bots] | 
| 
tandrii(chromium)
2015/09/17 12:45:21
do bot names always have no spaces?
 
Michael Achenbach
2015/09/17 12:52:14
For trybots we follow this convention everywhere o
 | 
| + benchmarks = ['"%s"' % benchmark for benchmark in options.benchmarks] | 
| + cmd += ['-p \'testfilter=[%s]\'' % ','.join(benchmarks)] | 
| + subprocess.check_call(' '.join(cmd), shell=True, cwd=V8_BASE) | 
| + | 
| if __name__ == "__main__": # pragma: no cover | 
| sys.exit(main()) |