Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1351093002: [test] Switch perf try wrapper to buildbucket. (Closed)

Created:
5 years, 3 months ago by Michael Achenbach
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Switch perf try wrapper to buildbucket. NOTRY=true Committed: https://crrev.com/d7c8b9bac64f53233fd36536a05807b338fa0794 Cr-Commit-Position: refs/heads/master@{#30801}

Patch Set 1 #

Patch Set 2 : Upload depot_tools #

Patch Set 3 : Add some mobile trybots... #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -26 lines) Patch
M tools/try_perf.py View 1 2 3 chunks +16 lines, -26 lines 3 comments Download

Messages

Total messages: 9 (2 generated)
Michael Achenbach
PTAL
5 years, 3 months ago (2015-09-17 12:38:51 UTC) #2
tandrii(chromium)
lgtm https://codereview.chromium.org/1351093002/diff/40001/tools/try_perf.py File tools/try_perf.py (right): https://codereview.chromium.org/1351093002/diff/40001/tools/try_perf.py#newcode47 tools/try_perf.py:47: # Ensure depot_tools are updated. nice! https://codereview.chromium.org/1351093002/diff/40001/tools/try_perf.py#newcode52 tools/try_perf.py:52: ...
5 years, 3 months ago (2015-09-17 12:45:21 UTC) #3
Michael Achenbach
https://codereview.chromium.org/1351093002/diff/40001/tools/try_perf.py File tools/try_perf.py (right): https://codereview.chromium.org/1351093002/diff/40001/tools/try_perf.py#newcode52 tools/try_perf.py:52: cmd += ['-b %s' % bot for bot in ...
5 years, 3 months ago (2015-09-17 12:52:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351093002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351093002/40001
5 years, 3 months ago (2015-09-17 13:38:22 UTC) #6
Jakob Kummerow
rubberstamp LGTM in case the CQ wants one
5 years, 3 months ago (2015-09-17 13:40:27 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-17 13:41:35 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 13:41:48 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/d7c8b9bac64f53233fd36536a05807b338fa0794
Cr-Commit-Position: refs/heads/master@{#30801}

Powered by Google App Engine
This is Rietveld 408576698