LayoutTests/svg/as-object/embedded-svg-immediate-offsetWidth-query.html - Issue 135103003: Updating <object> upon changing "data", "classid", "type" attributes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/svg/as-object/embedded-svg-immediate-offsetWidth-query.html

Issue 135103003: Updating <object> upon changing "data", "classid", "type" attributes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase (another TestExpectations conflict) Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/HTMLObjectElement/update-data-expected.txt ('k') | LayoutTests/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt » ('j') | Source/core/html/HTMLObjectElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/svg/as-object/embedded-svg-immediate-offsetWidth-query.html

diff --git a/LayoutTests/svg/as-object/embedded-svg-immediate-offsetWidth-query.html b/LayoutTests/svg/as-object/embedded-svg-immediate-offsetWidth-query.html

index 446966d1c2a3aeb588f71189e5cbd131cd3a4b22..ec59a35dd614adcc87601847ba9097797affb691 100644

--- a/LayoutTests/svg/as-object/embedded-svg-immediate-offsetWidth-query.html

+++ b/LayoutTests/svg/as-object/embedded-svg-immediate-offsetWidth-query.html

@@ -1,6 +1,9 @@

<head>

-<script>window.enablePixelTesting = true;</script>

+<script>

+window.enablePixelTesting = true;

+window.jsTestIsAsync = true;

+</script>

@@ -16,11 +19,15 @@

shouldBe("newObject.offsetWidth", "302");

- // Switch to document: "<svg xmlns="http://www.w3.org/2000/svg" width="400" height="200"><rect width="400" height="200" fill="green"/></svg>".

- // FIXME: This currently fails in WebKit trunk. We don't react on dataAttr changes at all. When manually relayouting using eg. zoom in/out it takes affect.

- newObject.setAttribute("data", "data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHdpZHRoPSI0MDAiIGhlaWdodD0iMjAwIj48cmVjdCB3aWR0aD0iNDAwIiBoZWlnaHQ9IjIwMCIgZmlsbD0iZ3JlZW4iLz48L3N2Zz4=");

- shouldBe("newObject.offsetWidth", "502");

+ // Switch to document: "<svg xmlns="http://www.w3.org/2000/svg" width="400" height="200"><rect width="400" height="200" fill="green"/><script><![CDATA[window.parent.postMessage('running', '*');]]></script></svg>".

+ // The replacement won't synchronous; wait on its completion.

+ window.onmessage = function () {

+ shouldBe("newObject.offsetWidth", "402");

+ finishJSTest();

+ };

+ newObject.setAttribute("data", "data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHdpZHRoPSI0MDAiIGhlaWdodD0iMjAwIj48cmVjdCB3aWR0aD0iNDAwIiBoZWlnaHQ9IjIwMCIgZmlsbD0iZ3JlZW4iLz48c2NyaXB0PjwhW0NEQVRBW3dpbmRvdy5wYXJlbnQucG9zdE1lc3NhZ2UoJ3J1bm5pbmcnLCAnKicpO11dPjwvc2NyaXB0Pjwvc3ZnPg==");

}

</script>

</head>