Updating <object> upon changing "data", "classid", "type" attributes.

Source/core/html/HTMLObjectElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Stefan Schimanski (1Stein@gmx.de)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 80 matching lines @@
 
 void HTMLObjectElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
 {
     if (name == formAttr)
         formAttributeChanged();
     else if (name == typeAttr) {
         m_serviceType = value.lower();
         size_t pos = m_serviceType.find(";");
         if (pos != kNotFound)
             m_serviceType = m_serviceType.left(pos);
-        if (renderer())
+        if (renderer()) {

[esprehn, 2014/01/15 00:16:38]

Blah, this isn't right, if the thing was display: none we still need to do the
setNeedsWidgetUpdate and setNeedsStyleRecalc. I guess we can't load plugins
without a renderer today so it doesn't matter, but we'll have to fix this
someday.

[sof, 2014/01/15 15:26:58]

ok, I went ahead & did it here/now.

             setNeedsWidgetUpdate(true);
+            // Per spec, only re-determine representation iff 'classid' and 'data' aren't present.

[eseidel, 2014/01/15 00:09:41]

setNeedsWidgetUpdate is going to cause a recalc, no?

[esprehn, 2014/01/15 00:16:38]

no, it just sets a boolean, that whole system is busted. :(

+            if (inDocument() && !fastHasAttribute(classidAttr) && !fastHasAttribute(dataAttr))

[esprehn, 2014/01/15 00:16:38]

You don't need the inDocument() check, setNeedsStyleRecalc checks it for you.

[sof, 2014/01/15 15:26:58]

Done.

+                setNeedsStyleRecalc();
+        }
     } else if (name == dataAttr) {
         m_url = stripLeadingAndTrailingHTMLSpaces(value);
         if (renderer()) {
             setNeedsWidgetUpdate(true);
             if (isImageType()) {
                 if (!m_imageLoader)
                     m_imageLoader = adoptPtr(new HTMLImageLoader(this));
                 m_imageLoader->updateFromElementIgnoringPreviousError();
+            } else if (inDocument() && !fastHasAttribute(classidAttr)) {

[esprehn, 2014/01/15 00:16:38]

Same, don't check inDocument()

[sof, 2014/01/15 15:26:58]

Done.

+                setNeedsStyleRecalc();
             }
         }
     } else if (name == classidAttr) {
         m_classId = value;
-        if (renderer())
+        if (renderer()) {
             setNeedsWidgetUpdate(true);
+            // Always re-determine representation upon 'classid' changing.
+            if (inDocument())

[esprehn, 2014/01/15 00:16:38]

Remove inDocument()

[sof, 2014/01/15 15:26:58]

Done.

+                setNeedsStyleRecalc();
+        }
     } else if (name == onbeforeloadAttr) {
         setAttributeEventListener(EventTypeNames::beforeload, createAttributeEventListener(this, name, value));
     } else {
         HTMLPlugInElement::parseAttribute(name, value);
     }
 }
 
 static void mapDataParamToSrc(Vector<String>* paramNames, Vector<String>* paramValues)
 {
     // Some plugins don't understand the "data" attribute of the OBJECT tag (i.e. Real and WMP
@@ skipping 327 matching lines @@
 {
     return fastHasAttribute(usemapAttr);
 }
 
 bool HTMLObjectElement::useFallbackContent() const
 {
     return HTMLPlugInElement::useFallbackContent() || m_useFallbackContent;
 }
 
 }