Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: LayoutTests/paint/selection/resources/selection.js

Issue 1350973003: Invalidate line break selection rects when selected. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Don't need redundant early-out for selection rect. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/paint/selection/invalidation-rect-with-br-includes-newline-expected.txt ('k') | LayoutTests/paint/selection/text-selection-newline-across-blocks.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 function selectRange(startElement, startIndex, endElement, endIndex) { 1 function selectRangeAfterLayoutAndPaint(startElement, startIndex, endElement, en dIndex) {
2 runAfterLayoutAndPaint(function() { 2 runAfterLayoutAndPaint(function() {
3 if (window.internals) 3 selectRange(startElement, startIndex, endElement, endIndex);
4 window.internals.setSelectionPaintingWithoutSelectionGapsEnabled(tru e);
5 var range = document.createRange();
6 range.setStart(startElement, startIndex);
7 range.setEnd(endElement, endIndex);
8 window.getSelection().addRange(range);
9 }, true); 4 }, true);
10 } 5 }
6
7 function selectRange(startElement, startIndex, endElement, endIndex) {
8 if (window.internals)
9 window.internals.setSelectionPaintingWithoutSelectionGapsEnabled(true);
10 var range = document.createRange();
11 range.setStart(startElement, startIndex);
12 range.setEnd(endElement, endIndex);
13 window.getSelection().addRange(range);
14 }
OLDNEW
« no previous file with comments | « LayoutTests/paint/selection/invalidation-rect-with-br-includes-newline-expected.txt ('k') | LayoutTests/paint/selection/text-selection-newline-across-blocks.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698