LayoutTests/paint/selection/invalidation-rect-includes-newline.html - Issue 1350973003: Invalidate line break selection rects when selected.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/paint/selection/invalidation-rect-includes-newline.html

Issue 1350973003: Invalidate line break selection rects when selected. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Don't need redundant early-out for selection rect. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../resources/ahem.js"></script>	2 <script src="../../resources/ahem.js"></script>

3 <script src="../../fast/repaint/resources/text-based-repaint.js"></script>	3 <script src="../../fast/repaint/resources/text-based-repaint.js"></script>

	4 <script src="resources/selection.js"></script>

4 <script>	5 <script>

5 // Selects two lines and expects a newline to be represented.	6 // Selects two lines and expects a newline to be represented.

6 function repaintTest() {	7 function repaintTest() {

7 if (window.internals)	8 selectRange(container, 0, container, 1);

8 window.internals.setSelectionPaintingWithoutSelectionGapsEnabled(true);

9 var range = document.createRange();

10 range.setStart(container, 0);

11 range.setEnd(container, 1);

12 window.getSelection().addRange(range);

13 };	9 };

14 window.onload = runRepaintTest;	10 window.onload = runRepaintTest;

15 </script>	11 </script>

16 <style>	12 <style>

17 div {	13 div {

18 font-family: Ahem;	14 font-family: Ahem;

19 width: 2em;	15 width: 2em;

20 }	16 }

21 </style>	17 </style>

22 <div id="container">	18 <div id="container">

23 xx y	19 xx y

24 </div>	20 </div>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/paint/selection/invalidation-rect-with-br-includes-newline.html » ('j') | no next file with comments »