runtime/vm/scavenger.cc - Issue 1350933004: Distinct block sizes for StoreBuffer/MarkingStack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/scavenger.cc

Issue 1350933004: Distinct block sizes for StoreBuffer/MarkingStack. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Ready for review. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/scavenger.cc

diff --git a/runtime/vm/scavenger.cc b/runtime/vm/scavenger.cc

index fd1256e57d8dda6181294a9220d143b7b51c68fb..bcb8bbe135d1534ce5c7aafba689734c26e2b0f2 100644

--- a/runtime/vm/scavenger.cc

+++ b/runtime/vm/scavenger.cc

@@ -526,7 +526,8 @@ void Scavenger::IterateStoreBuffers(Isolate* isolate,

raw_object->VisitPointers(visitor);

}

pending->Reset();

- isolate->store_buffer()->PushBlock(pending);

+ // Return the emptied block for recycling (no need to check threshold).

+ isolate->store_buffer()->PushBlock(pending, false);

pending = next;

}

heap_->RecordData(kStoreBufferEntries, total_count);