Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Unified Diff: Source/core/events/KeyboardEvent.cpp

Issue 1350933003: Implement MouseEvent.getModifierState (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add LayoutTests Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/events/KeyboardEvent.cpp
diff --git a/Source/core/events/KeyboardEvent.cpp b/Source/core/events/KeyboardEvent.cpp
index 54e373d63e29d822fea49978759ac7cbd8d23188..fc5e78259aafc36931cad0b1a6ef7eaae96e06b5 100644
--- a/Source/core/events/KeyboardEvent.cpp
+++ b/Source/core/events/KeyboardEvent.cpp
@@ -154,21 +154,6 @@ void KeyboardEvent::initKeyboardEvent(ScriptState* scriptState, const AtomicStri
m_metaKey = metaKey;
}
-bool KeyboardEvent::getModifierState(const String& keyIdentifier) const
-{
- // FIXME: The following keyIdentifiers are not supported yet (crbug.com/265458):
- // "AltGraph", "CapsLock", "Fn", "NumLock", "ScrollLock", "SymbolLock", "OS".
- if (keyIdentifier == "Control")
- return ctrlKey();
- if (keyIdentifier == "Shift")
- return shiftKey();
- if (keyIdentifier == "Alt")
- return altKey();
- if (keyIdentifier == "Meta")
- return metaKey();
- return false;
-}
-
int KeyboardEvent::keyCode() const
{
// IE: virtual key code for keyup/keydown, character code for keypress

Powered by Google App Engine
This is Rietveld 408576698