Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: components/navigation_interception/intercept_navigation_delegate.h

Issue 1350913008: Revert of Add a NavigationThrottle to the public content/ interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@navigation-api
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/navigation_interception/intercept_navigation_delegate.h
diff --git a/components/navigation_interception/intercept_navigation_delegate.h b/components/navigation_interception/intercept_navigation_delegate.h
index 57858fdc92dd905f119295a9c947b6283db4d969..d84969f0796fa9c14ea0120391772a792ec0d77d 100644
--- a/components/navigation_interception/intercept_navigation_delegate.h
+++ b/components/navigation_interception/intercept_navigation_delegate.h
@@ -12,8 +12,7 @@
class GURL;
namespace content {
-class NavigationHandle;
-class NavigationThrottle;
+class ResourceThrottle;
class WebContents;
}
@@ -33,8 +32,9 @@
// 1) the Java-side interface implementation must be associated (via the
// Associate method) with a WebContents for which URLRequests are to be
// intercepted,
-// 2) the NavigationThrottle obtained via CreateThrottleFor must be associated
-// with the NavigationHandle in the ContentBrowserClient implementation.
+// 2) the ResourceThrottle obtained via CreateThrottleFor must be associated
+// with the URLRequests in the ResourceDispatcherHostDelegate
+// implementation.
class InterceptNavigationDelegate : public base::SupportsUserData::Data {
public:
InterceptNavigationDelegate(JNIEnv* env, jobject jdelegate);
@@ -50,10 +50,10 @@
// can be null.
static InterceptNavigationDelegate* Get(content::WebContents* web_contents);
- // Creates a InterceptNavigationThrottle that will direct all callbacks to
- // the InterceptNavigationDelegate.
- static scoped_ptr<content::NavigationThrottle> CreateThrottleFor(
- content::NavigationHandle* handle);
+ // Creates a InterceptNavigationResourceThrottle that will direct all
+ // callbacks to the InterceptNavigationDelegate.
+ static content::ResourceThrottle* CreateThrottleFor(
+ net::URLRequest* request);
// Updates information to determine whether to have user gesture carryover or
// not.
« no previous file with comments | « components/navigation_interception/BUILD.gn ('k') | components/navigation_interception/intercept_navigation_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698