Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9070)

Unified Diff: chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc

Issue 1350913008: Revert of Add a NavigationThrottle to the public content/ interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@navigation-api
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | components/components_tests.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
diff --git a/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc b/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
index b28332ea3809ee058b9b810f1b6d44be397b5319..aa4705e9c628f7ffdb6ba3162844bff8c2f5fb87 100644
--- a/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
+++ b/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
@@ -339,8 +339,25 @@
resource_context);
#if defined(OS_ANDROID)
- if (resource_type != content::RESOURCE_TYPE_MAIN_FRAME)
- InterceptNavigationDelegate::UpdateUserGestureCarryoverInfo(request);
+ // TODO(davidben): This is insufficient to integrate with prerender properly.
+ // https://crbug.com/370595
+ if (!is_prerendering) {
+ if (resource_type == content::RESOURCE_TYPE_MAIN_FRAME) {
+ throttles->push_back(
+ InterceptNavigationDelegate::CreateThrottleFor(request));
+ } else {
+ InterceptNavigationDelegate::UpdateUserGestureCarryoverInfo(request);
+ }
+ }
+#else
+ if (resource_type == content::RESOURCE_TYPE_MAIN_FRAME) {
+ // Redirect some navigations to apps that have registered matching URL
+ // handlers ('url_handlers' in the manifest).
+ content::ResourceThrottle* url_to_app_throttle =
+ AppUrlRedirector::MaybeCreateThrottleFor(request, io_data);
+ if (url_to_app_throttle)
+ throttles->push_back(url_to_app_throttle);
+ }
#endif
#if defined(OS_CHROMEOS)
« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | components/components_tests.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698