Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1350913006: Revert of Add source column to chrome://policy showing the origins of policies. (Closed)

Created:
5 years, 3 months ago by dgrogan
Modified:
5 years, 3 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add source column to chrome://policy showing the origins of policies. (patchset #18 id:620001 of https://codereview.chromium.org/1304843004/ ) Reason for revert: Fix google chrome compile. http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/4220/steps/compile/logs/stdio ../../chrome/browser/ui/startup/startup_browser_creator_browsertest.cc:1235:23:error: too few arguments to function call, expected 6, have 5 NULL); ^ ../../components/policy/core/common/policy_map.h:66:3: note: 'Set' declared here void Set(const std::string& policy, ^ Original issue's description: > Add source column to chrome://policy showing the origins of policies. > > These are the possible sources for a policy: > Cloud - Policy values received from the cloud. > Platform - Local configured policies. > Enterprise Default - Defaults for policies in enterprise environments > on Chrome OS. Can be overridden. > Enterprise Override - Policies enforced in enterprise environments on > Chrome OS. Can NOT be overridden. > > The source of a policy is determined when it's first set. For cloud > policies, this would be the decoding of the protocol buffers. > Platform policies are usually set by loading platform-specific local > configurations like entries in the Windows registry. > Enterprise defaults are automatically set if the device is active in > an enterprise environment. > Enterprise override policies are set within the code to enforce > specific behaviors (like ash tray visibility). They cannot be > overridden. > > BUG=506123 > TBR=jam@chromium.org > > Committed: https://crrev.com/92e7960f06c2ac2ec0113bb88df3d322f0eb97fe > Cr-Commit-Position: refs/heads/master@{#349654} > > Committed: https://crrev.com/2c4ce2a1988fdde3456e49112eba6c7855ca4528 > Cr-Commit-Position: refs/heads/master@{#349749} TBR=tnagel@chromium.org,bartfab@chromium.org,dbeam@chromium.org,jam@chromium.org,fhorschig@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=506123 Committed: https://crrev.com/c8778b84c83b210d60046b538e9d16cfc1f534cd Cr-Commit-Position: refs/heads/master@{#349774}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -977 lines) Patch
M build/ios/grit_whitelist.txt View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/saml/saml_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/policy/cloud_external_data_manager_base_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/cloud_external_data_policy_observer_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/configuration_policy_handler_chromeos_unittest.cc View 17 chunks +2 lines, -19 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_policy_provider.cc View 6 chunks +2 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc View 5 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc View 55 chunks +2 lines, -56 lines 0 comments Download
M chrome/browser/chromeos/policy/login_profile_policy_provider.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc View 8 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/system/tray_accessibility_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/download/download_dir_policy_handler_unittest.cc View 5 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_apitest_nss.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/management/management_browsertest.cc View 4 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_messaging_policy_handler_unittest.cc View 8 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/policy_value_store_unittest.cc View 5 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_apitest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_management_test_util.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/policy_handlers_unittest.cc View 23 chunks +0 lines, -23 lines 0 comments Download
M chrome/browser/net/disk_cache_dir_policy_handler_unittest.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/net/proxy_policy_handler_unittest.cc View 15 chunks +0 lines, -26 lines 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_browsertest.cc View 3 chunks +3 lines, -17 lines 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_invalidator_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/policy/file_selection_dialogs_policy_handler_unittest.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/policy/javascript_policy_handler_unittest.cc View 5 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/policy/managed_bookmarks_policy_handler_unittest.cc View 5 chunks +3 lines, -14 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 88 chunks +36 lines, -141 lines 0 comments Download
M chrome/browser/policy/policy_network_browsertest.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/policy/policy_prefs_browsertest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/policy/policy_startup_browsertest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/policy/profile_policy_connector_unittest.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/prefs/proxy_policy_unittest.cc View 5 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/profiles/incognito_mode_policy_handler_unittest.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/policy.html View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/policy.js View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/search/contextual_search_policy_handler_android_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/sessions/restore_on_startup_policy_handler_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_browsertest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/certificate_manager_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/preferences_browsertest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/policy_ui.cc View 6 chunks +1 line, -28 lines 0 comments Download
M chrome/browser/ui/webui/policy_ui_browsertest.cc View 8 chunks +7 lines, -20 lines 0 comments Download
M components/policy/core/browser/android/policy_converter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/policy/core/browser/autofill_policy_handler_unittest.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M components/policy/core/browser/configuration_policy_handler_unittest.cc View 46 chunks +16 lines, -60 lines 0 comments Download
M components/policy/core/browser/configuration_policy_pref_store_unittest.cc View 7 chunks +2 lines, -8 lines 0 comments Download
M components/policy/core/browser/url_blacklist_policy_handler_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M components/policy/core/common/async_policy_provider_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_manager_unittest.cc View 6 chunks +7 lines, -23 lines 0 comments Download
M components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M components/policy/core/common/cloud/component_cloud_policy_store.cc View 2 chunks +1 line, -3 lines 0 comments Download
M components/policy/core/common/cloud/component_cloud_policy_store_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M components/policy/core/common/cloud/component_cloud_policy_updater_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/policy/core/common/cloud/user_cloud_policy_manager_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M components/policy/core/common/config_dir_policy_loader.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M components/policy/core/common/config_dir_policy_loader_unittest.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M components/policy/core/common/configuration_policy_provider_test.h View 3 chunks +4 lines, -8 lines 0 comments Download
M components/policy/core/common/configuration_policy_provider_test.cc View 7 chunks +3 lines, -13 lines 0 comments Download
M components/policy/core/common/generate_policy_source_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/policy/core/common/policy_bundle_unittest.cc View 8 chunks +3 lines, -17 lines 0 comments Download
M components/policy/core/common/policy_loader_ios.mm View 1 chunk +1 line, -2 lines 0 comments Download
M components/policy/core/common/policy_loader_ios_unittest.mm View 3 chunks +3 lines, -7 lines 0 comments Download
M components/policy/core/common/policy_loader_mac.mm View 2 chunks +4 lines, -4 lines 0 comments Download
M components/policy/core/common/policy_loader_mac_unittest.cc View 3 chunks +1 line, -4 lines 0 comments Download
M components/policy/core/common/policy_loader_win.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M components/policy/core/common/policy_loader_win_unittest.cc View 12 chunks +13 lines, -28 lines 0 comments Download
M components/policy/core/common/policy_map.h View 3 chunks +3 lines, -8 lines 0 comments Download
M components/policy/core/common/policy_map.cc View 6 chunks +9 lines, -19 lines 0 comments Download
M components/policy/core/common/policy_map_unittest.cc View 9 chunks +11 lines, -87 lines 0 comments Download
M components/policy/core/common/policy_service_impl.cc View 4 chunks +0 lines, -5 lines 0 comments Download
M components/policy/core/common/policy_service_impl_unittest.cc View 29 chunks +13 lines, -49 lines 0 comments Download
M components/policy/core/common/policy_statistics_collector_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/policy/core/common/policy_types.h View 1 chunk +0 lines, -20 lines 0 comments Download
M components/policy/core/common/proxy_policy_provider_unittest.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M components/policy/core/common/schema_map_unittest.cc View 11 chunks +4 lines, -24 lines 0 comments Download
M components/policy/core/common/schema_registry_tracking_policy_provider_unittest.cc View 5 chunks +0 lines, -5 lines 0 comments Download
M components/policy/tools/generate_policy_source.py View 4 chunks +3 lines, -9 lines 0 comments Download
M components/policy_strings.grdp View 2 chunks +0 lines, -15 lines 0 comments Download
M components/search_engines/default_search_policy_handler_unittest.cc View 6 chunks +3 lines, -21 lines 0 comments Download
M components/sync_driver/sync_policy_handler_unittest.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M remoting/host/policy_watcher_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M tools/gritsettings/resource_ids View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dgrogan
Created Revert of Add source column to chrome://policy showing the origins of policies.
5 years, 3 months ago (2015-09-18 21:27:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350913006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350913006/1
5 years, 3 months ago (2015-09-18 21:28:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-18 21:30:26 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 21:31:11 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c8778b84c83b210d60046b538e9d16cfc1f534cd
Cr-Commit-Position: refs/heads/master@{#349774}

Powered by Google App Engine
This is Rietveld 408576698