Add UX for languages that don't have any associated input method

chrome/browser/resources/options/language_options.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(kochi): Generalize the notification as a component and put it
 // in js/cr/ui/notification.js .
 
 cr.define('options', function() {
   /** @const */ var OptionsPage = options.OptionsPage;
   /** @const */ var LanguageList = options.LanguageList;
@@ skipping 367 matching lines @@
       for (var i = 0; i < preloadEngines.length; i++) {
         preloadEngineSet[preloadEngines[i]] = true;
       }
 
       // Create the new preload engine list per the language codes.
       var newPreloadEngines = [];
       for (var i = 0; i < languageCodes.length; i++) {
         var languageCode = languageCodes[i];
         var inputMethodIds = this.languageCodeToInputMethodIdsMap_[
             languageCode];
+        if (!inputMethodIds)
+          continue;

[James Hawkins, 2013/04/05 18:41:50]

Optional nit: Add a blank line below this to increase readability.

[Zachary Kuznia, 2013/04/09 06:45:52]

Done.

         // Check if we have active input methods associated with the language.
         for (var j = 0; j < inputMethodIds.length; j++) {
           var inputMethodId = inputMethodIds[j];
           if (inputMethodId in preloadEngineSet) {
             // If we have, add it to the new engine list.
             newPreloadEngines.push(inputMethodId);
             // And delete it from the set. This is necessary as one input
             // method can be associated with more than one language thus
             // we should avoid having duplicates in the new list.
             delete preloadEngineSet[inputMethodId];
@@ skipping 174 matching lines @@
           var input = method.querySelector('input');
           // Give it focus if the ID matches.
           if (input.inputMethodId == focusInputMethodId) {
             input.focus();
           }
         } else {
           method.hidden = true;
         }
       }
 
+      $('language-options-input-method-none').hidden =
+          (languageCode in this.languageCodeToInputMethodIdsMap_);
+
       if (focusInputMethodId == 'add') {
         $('language-options-add-button').focus();
       }
     },
 
     /**
      * Updates the language list in the add language overlay.
      * @param {string} languageCode Language code (ex. "fr").
      * @private
      */
@@ skipping 199 matching lines @@
      *
      * @param {string} languageCode Language code (ex. "fr").
      * @return {boolean} Returns true on success.
      * @private
      */
     canDeleteLanguage_: function(languageCode) {
       // First create the set of engines to be removed from input methods
       // associated with the language code.
       var enginesToBeRemovedSet = {};
       var inputMethodIds = this.languageCodeToInputMethodIdsMap_[languageCode];
+
+      // If this language doesn't have any input methods, it can be deleted.
+      if (!inputMethodIds)
+        return true;
+
       for (var i = 0; i < inputMethodIds.length; i++) {
         enginesToBeRemovedSet[inputMethodIds[i]] = true;
       }
 
       // Then eliminate engines that are also used for other active languages.
       // For instance, if "xkb:us::eng" is used for both English and Filipino.
       var languageCodes = $('language-options-list').getLanguageCodes();
       for (var i = 0; i < languageCodes.length; i++) {
         // Skip the target language code.
         if (languageCodes[i] == languageCode) {
           continue;
         }
         // Check if input methods used in this language are included in
         // enginesToBeRemovedSet. If so, eliminate these from the set, so
         // we don't remove this time.
         var inputMethodIdsForAnotherLanguage =
             this.languageCodeToInputMethodIdsMap_[languageCodes[i]];
+        if (!inputMethodIdsForAnotherLanguage)
+          continue;

[James Hawkins, 2013/04/05 18:41:50]

Optional nit: Add a blank line below this to increase readability.

[Zachary Kuznia, 2013/04/09 06:45:52]

Done.

         for (var j = 0; j < inputMethodIdsForAnotherLanguage.length; j++) {
           var inputMethodId = inputMethodIdsForAnotherLanguage[j];
           if (inputMethodId in enginesToBeRemovedSet) {
             delete enginesToBeRemovedSet[inputMethodId];
           }
         }
       }
 
       // Update the preload engine list with the to-be-removed set.
       var newPreloadEngines = [];
@@ skipping 264 matching lines @@
 
   LanguageOptions.onDictionaryDownloadFailure = function(languageCode) {
     LanguageOptions.getInstance().onDictionaryDownloadFailure_(languageCode);
   };
 
   // Export
   return {
     LanguageOptions: LanguageOptions
   };
 });