Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1350893002: Revert of Don't refer browser-initiated navigations to web-safe URLs to delegate. (Closed)

Created:
5 years, 3 months ago by wjmaclean
Modified:
5 years, 3 months ago
Reviewers:
Charlie Reis, lazyboy
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Don't refer browser-initiated navigations to web-safe URLs to delegate. (patchset #2 id:20001 of https://codereview.chromium.org/1234403005/ ) Reason for revert: Since this CL was landed something has changed that causes clinking on links in the PDF viewer (embedded inside another WebView, e.g. the Chrome app "Browser Sample") to open in the wrong window, or in the case of "Open in a new tab", not be opened at all. Reverting this CL fixes https://code.google.com/p/chromium/issues/detail?id=529187 and https://code.google.com/p/chromium/issues/detail?id=521573 A new bug has been filed to capture the error where the links are not opened in the correct target window: https://code.google.com/p/chromium/issues/detail?id=532621 Original issue's description: > Don't refer browser-initiated navigations to web-safe URLs to delegate. > > In a previous CL (https://codereview.chromium.org/890183002) it was > decided to refer browser-initiated navigations to the owner WebContents' > delegate, on the assumption that the navigation was to a non-web-safe > url (e.g. a "chrome"-scheme url). However, this change can block > guest navigations to web-safe URLs just because they originated, for > example, from an extension. > > This CL ensures that navigations to web-safe URLs are not referred to > the delegate in order to allow them to succeed. > > BUG=488053 > > Committed: https://crrev.com/a03c23d32d176daf1e95cfffbfa333316e1eb1a6 > Cr-Commit-Position: refs/heads/master@{#339204} TBR=creis@chromium.org,lazyboy@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=488053 Committed: https://crrev.com/b7d53cf36c29e13532afa89aa09fd89e8e1c8e95 Cr-Commit-Position: refs/heads/master@{#349208}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -35 lines) Patch
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.cc View 1 chunk +11 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
wjmaclean
Created Revert of Don't refer browser-initiated navigations to web-safe URLs to delegate.
5 years, 3 months ago (2015-09-16 20:15:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350893002/1
5 years, 3 months ago (2015-09-16 20:16:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-16 20:18:40 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b7d53cf36c29e13532afa89aa09fd89e8e1c8e95 Cr-Commit-Position: refs/heads/master@{#349208}
5 years, 3 months ago (2015-09-16 20:20:10 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 13:00:02 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b7d53cf36c29e13532afa89aa09fd89e8e1c8e95
Cr-Commit-Position: refs/heads/master@{#349208}

Powered by Google App Engine
This is Rietveld 408576698