Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 1350843003: Add ScopeInfo constants to post-mortem metadata (Closed)

Created:
5 years, 3 months ago by julien.gilli
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add ScopeInfo constants to post-mortem metadata mdb_v8, a post-mortem debugging tool for Node.js, allows users to inspect ScopeInfo structures in order to get more information about closures. Currently, it hardcodes the metadata it uses to find this information. This change allows it to get this metadata from the node binary itself, and thus to adapt to future changes made to the layout of the ScopeInfo data structure. BUG= R=bmeurer@chromium.org Committed: https://crrev.com/357e6b99ee3927cc075dd8d27c99b89d858f9dd5 Cr-Commit-Position: refs/heads/master@{#30843}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M src/objects.h View 2 chunks +1 line, -1 line 0 comments Download
M tools/gen-postmortem-metadata.py View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
julien.gilli
5 years, 3 months ago (2015-09-21 04:48:35 UTC) #1
Benedikt Meurer
lgtm
5 years, 3 months ago (2015-09-21 04:49:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350843003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350843003/1
5 years, 3 months ago (2015-09-21 05:13:24 UTC) #5
julien.gilli
On 2015/09/21 04:49:17, Benedikt Meurer wrote: > lgtm Thank you very much for the prompt ...
5 years, 3 months ago (2015-09-21 05:15:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-21 05:45:26 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 05:45:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/357e6b99ee3927cc075dd8d27c99b89d858f9dd5
Cr-Commit-Position: refs/heads/master@{#30843}

Powered by Google App Engine
This is Rietveld 408576698