Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 135083002: Clarify chrome.events as a namespace of common types. (Closed)

Created:
6 years, 11 months ago by scheib
Modified:
6 years, 11 months ago
Reviewers:
rpaquay
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Clarify chrome.events as a namespace of common types. Particualarly for apps documentation, a developer who first encounters chrome.events may be slightly confused about all the documentation without the context that it is all in support of other APIs. BUG=325011 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244385

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M chrome/common/extensions/api/events.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/intros/events.html View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scheib
Doc preview: https://chrome-apps-doc.appspot.com/_patch/12345678/apps/events.html https://chrome-apps-doc.appspot.com/_patch/12345678/extensions/events.html
6 years, 11 months ago (2014-01-10 23:02:15 UTC) #1
rpaquay
lgtm https://codereview.chromium.org/135083002/diff/30001/chrome/common/extensions/api/events.json File chrome/common/extensions/api/events.json (right): https://codereview.chromium.org/135083002/diff/30001/chrome/common/extensions/api/events.json#newcode8 chrome/common/extensions/api/events.json:8: "description": "The <code>chrome.events</code> namespace contains common types used ...
6 years, 11 months ago (2014-01-10 23:50:46 UTC) #2
scheib
Thanks. https://codereview.chromium.org/135083002/diff/30001/chrome/common/extensions/api/events.json File chrome/common/extensions/api/events.json (right): https://codereview.chromium.org/135083002/diff/30001/chrome/common/extensions/api/events.json#newcode8 chrome/common/extensions/api/events.json:8: "description": "The <code>chrome.events</code> namespace contains common types used ...
6 years, 11 months ago (2014-01-10 23:58:30 UTC) #3
rpaquay
lgtm
6 years, 11 months ago (2014-01-11 00:03:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/135083002/100001
6 years, 11 months ago (2014-01-11 00:23:50 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-11 23:11:09 UTC) #6
Message was sent while issue was closed.
Change committed as 244385

Powered by Google App Engine
This is Rietveld 408576698