Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1350823002: Revert of Reland #2 "ipc: Add a new field num_brokered_attachments to the message header." (Closed)

Created:
5 years, 3 months ago by erikchen
Modified:
5 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland #2 "ipc: Add a new field num_brokered_attachments to the message header." (patchset #5 id:80001 of https://codereview.chromium.org/1334593002/ ) Reason for revert: CL was only ever intended to be in 1 canary release. Original issue's description: > Reland #2 "ipc: Add a new field num_brokered_attachments to the message header." > > This original version of this CL is causing an unusual crash in Canary. This CL > adds a message verifier to the ipc code so that it can dynamically verify the > contents of this message that is being corrupted. This CL also verifies the > message at several different points in the dispatch process. This will help > narrow down the range of code that is corrupting the message. > > I expect this CL to cause ~100 crashes in the next Chrome Canary. I intend to > revert this CL after a single Canary release. > > BUG=527588 > > Committed: https://crrev.com/a2e71be46dc4bdcbb544db479680f65a390ae8f3 > Cr-Commit-Position: refs/heads/master@{#349056} TBR=avi@chromium.org,tsepez@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=527588 Committed: https://crrev.com/1fa7dad91bc711eb1e481aa467a2f38c77cdae54 Cr-Commit-Position: refs/heads/master@{#349152}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -111 lines) Patch
M content/browser/browser_main_loop.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M content/browser/loader/async_resource_handler.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/child/child_thread_impl.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M content/child/resource_dispatcher.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M content/child/resource_scheduling_filter.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M content/child/threaded_data_provider.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/common/resource_messages.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/common/resource_messages.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M ipc/ipc_channel.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ipc/ipc_channel_common.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M ipc/ipc_channel_reader.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M ipc/ipc_channel_win.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M ipc/ipc_message.h View 2 chunks +0 lines, -7 lines 0 comments Download
M ipc/ipc_message.cc View 5 chunks +2 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
erikchen
Created Revert of Reland #2 "ipc: Add a new field num_brokered_attachments to the message header."
5 years, 3 months ago (2015-09-16 17:33:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350823002/1
5 years, 3 months ago (2015-09-16 17:34:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-16 17:35:14 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1fa7dad91bc711eb1e481aa467a2f38c77cdae54 Cr-Commit-Position: refs/heads/master@{#349152}
5 years, 3 months ago (2015-09-16 17:36:24 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:57:20 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1fa7dad91bc711eb1e481aa467a2f38c77cdae54
Cr-Commit-Position: refs/heads/master@{#349152}

Powered by Google App Engine
This is Rietveld 408576698